feat: add flexible custom attributes system to replace hardcoded prerogatives

- Create software_attribute_definitions table with attribute metadata
- Add customAttributes JSONB column to softwares table with GIN index
- Migrate existing prerogatives (isPresentInSupportContract,
  isFromFrenchPublicService, doRespectRgaa) to custom attributes
- Create AttributeKind type ('boolean' | 'string' | 'number' | 'date' | 'url')
- Add AttributeDefinition and AttributeValue types
- Implement repository layer for attribute definitions
- Create getAttributeDefinitions use case
- Remove deprecated Prerogatives type

This enables project-specific attributes without code changes, making
the system more generic and reusable across different deployments.

Note: Type errors remain in use cases, tests, and adapters - will be
fixed in follow-up commits.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

feat: add software customAttributes and a table to define them software_attribute_definitions

Author: JeromeBu

api/scripts/seed.ts

@@ -71,9 +71,7 @@ const seed = async () => {
             similarSoftwareExternalDataIds: [],
             softwareLogoUrl: "https://react.dev/favicon.ico",
             softwareKeywords: ["javascript", "ui", "frontend", "library"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: false,
-            doRespectRgaa: null
+            customAttributes: {}
         },
         {
             softwareName: "Git",
@@ -89,9 +87,7 @@ const seed = async () => {
             similarSoftwareExternalDataIds: [],
             softwareLogoUrl: "https://git-scm.com/images/logos/downloads/Git-Icon-1788C.png",
             softwareKeywords: ["vcs", "version control", "git", "scm"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: false,
-            doRespectRgaa: null
+            customAttributes: {}
         },
         {
             softwareName: "OpenOffice",
@@ -108,9 +104,7 @@ const seed = async () => {
             similarSoftwareExternalDataIds: [],
             softwareLogoUrl: "https://www.openoffice.org/images/AOO_logos/AOO_Logo_FullColor.svg",
             softwareKeywords: ["office", "suite", "word", "spreadsheet", "presentation"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: false,
-            doRespectRgaa: null
+            customAttributes: {}
         },
         {
             softwareName: "VLC media player",
@@ -126,9 +120,7 @@ const seed = async () => {
             similarSoftwareExternalDataIds: [],
             softwareLogoUrl: "https://www.videolan.org/images/favicon.png",
             softwareKeywords: ["media", "player", "video", "audio", "vlc"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: false,
-            doRespectRgaa: null
+            customAttributes: {}
         },
         {
             softwareName: "GIMP",
@@ -144,9 +136,7 @@ const seed = async () => {
             similarSoftwareExternalDataIds: [],
             softwareLogoUrl: "https://www.gimp.org/images/wilber-big.png",
             softwareKeywords: ["image", "editor", "graphics", "gimp"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: false,
-            doRespectRgaa: null
+            customAttributes: {}
         },
         {
             softwareName: "Onyxia",
@@ -163,9 +153,7 @@ const seed = async () => {
             softwareLogoUrl:
                 "https://upload.wikimedia.org/wikipedia/commons/thumb/a/ab/Onyxia.svg/250px-Onyxia.svg.png",
             softwareKeywords: ["hébergement", "hosting", "plateforme", "platform", "cloud", "nuage"],
-            isPresentInSupportContract: false,
-            isFromFrenchPublicService: true,
-            doRespectRgaa: false
+            customAttributes: {}
         }
     ];
 

api/src/core/adapters/comptoirDuLibre/getCDLFormData.ts

@@ -30,10 +30,7 @@ const formatCDLSoftwareToExternalData = async (
         similarSoftwareExternalDataIds: [],
         softwareLogoUrl: logoUrl,
         softwareKeywords: keywords,
-
-        isPresentInSupportContract: false,
-        isFromFrenchPublicService: false,
-        doRespectRgaa: null
+        customAttributes: undefined
     };
 };
 

api/src/core/adapters/dbApi/kysely/createGetCompiledData.ts

@@ -42,10 +42,8 @@ export const createGetCompiledData = (db: Kysely<Database>) => async (): Promise
             "s.categories",
             "s.dereferencing",
             "s.description",
-            "s.doRespectRgaa",
             "s.generalInfoMd",
-            "s.isFromFrenchPublicService",
-            "s.isPresentInSupportContract",
+            "s.customAttributes",
             "s.isStillInObservation",
             "s.keywords",
             "s.license",
@@ -94,7 +92,7 @@ export const createGetCompiledData = (db: Kysely<Database>) => async (): Promise
                     addedByUserId,
                     similarExternalSoftwares,
                     dereferencing,
-                    doRespectRgaa,
+                    customAttributes,
                     users,
                     referents,
                     instances,
@@ -115,7 +113,7 @@ export const createGetCompiledData = (db: Kysely<Database>) => async (): Promise
                         addedByUserEmail: agentById[addedByUserId].email,
                         updateTime: new Date(+updateTime).getTime(),
                         referencedSinceTime: new Date(+referencedSinceTime).getTime(),
-                        doRespectRgaa,
+                        customAttributes,
                         softwareExternalData: softwareExternalData ?? undefined,
                         latestVersion: version,
                         dereferencing: dereferencing ?? undefined,

api/src/core/adapters/dbApi/kysely/createPgAttributeDefinitionRepository.ts

@@ -0,0 +1,25 @@
+// SPDX-FileCopyrightText: 2021-2025 DINUM <[email protected]>
+// SPDX-FileCopyrightText: 2024-2025 Université Grenoble Alpes
+// SPDX-License-Identifier: MIT
+
+import { Kysely } from "kysely";
+import { AttributeDefinitionRepository } from "../../../ports/DbApiV2";
+import { Database } from "./kysely.database";
+import { stripNullOrUndefinedValues } from "./kysely.utils";
+
+export const createPgAttributeDefinitionRepository = (db: Kysely<Database>): AttributeDefinitionRepository => ({
+    getAll: async () =>
+        db
+            .selectFrom("software_attribute_definitions")
+            .selectAll()
+            .orderBy("displayOrder", "asc")
+            .execute()
+            .then(rows => rows.map(row => stripNullOrUndefinedValues(row))),
+    getByName: async (name: string) =>
+        db
+            .selectFrom("software_attribute_definitions")
+            .selectAll()
+            .where("name", "=", name)
+            .executeTakeFirst()
+            .then(row => (row ? stripNullOrUndefinedValues(row) : undefined))
+});

api/src/core/adapters/dbApi/kysely/createPgDbApi.ts

@@ -11,6 +11,7 @@ import { createPgSessionRepository } from "./createPgSessionRepository";
 import { createPgSoftwareExternalDataRepository } from "./createPgSoftwareExternalDataRepository";
 import { createPgSoftwareRepository } from "./createPgSoftwareRepository";
 import { createPgSourceRepository } from "./createPgSourceRepository";
+import { createPgAttributeDefinitionRepository } from "./createPgAttributeDefinitionRepository";
 import {
     createPgSoftwareReferentRepository,
     createPgSoftwareUserRepository
@@ -27,6 +28,7 @@ export const createKyselyPgDbApi = (db: Kysely<Database>): DbApiV2 => {
         softwareReferent: createPgSoftwareReferentRepository(db),
         softwareUser: createPgSoftwareUserRepository(db),
         session: createPgSessionRepository(db),
+        attributeDefinition: createPgAttributeDefinitionRepository(db),
         getCompiledDataPrivate: createGetCompiledData(db)
     };
 };

api/src/core/adapters/dbApi/kysely/createPgSoftwareRepository.ts

@@ -38,9 +38,7 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                 referencedSinceTime,
                 isStillInObservation,
                 dereferencing,
-                doRespectRgaa,
-                isFromFrenchPublicService,
-                isPresentInSupportContract,
+                customAttributes,
                 softwareType,
                 workshopUrls,
                 categories,
@@ -67,9 +65,7 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                         updateTime: now,
                         dereferencing: JSON.stringify(dereferencing),
                         isStillInObservation, // Legacy field from SILL imported
-                        doRespectRgaa,
-                        isFromFrenchPublicService,
-                        isPresentInSupportContract,
+                        customAttributes: JSON.stringify(customAttributes),
                         softwareType: JSON.stringify(softwareType),
                         workshopUrls: JSON.stringify(workshopUrls), // Legacy field from SILL imported
                         categories: JSON.stringify(categories), // Legacy field from SILL imported
@@ -92,9 +88,7 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                 versionMin,
                 dereferencing,
                 isStillInObservation,
-                doRespectRgaa,
-                isFromFrenchPublicService,
-                isPresentInSupportContract,
+                customAttributes,
                 softwareType,
                 workshopUrls,
                 categories,
@@ -118,9 +112,7 @@ export const createPgSoftwareRepository = (db: Kysely<Database>): SoftwareReposi
                     dereferencing: JSON.stringify(dereferencing),
                     updateTime: now,
                     isStillInObservation: false,
-                    doRespectRgaa,
-                    isFromFrenchPublicService,
-                    isPresentInSupportContract,
+                    customAttributes: JSON.stringify(customAttributes),
                     softwareType: JSON.stringify(softwareType),
                     workshopUrls: JSON.stringify(workshopUrls),
                     categories: JSON.stringify(categories),

api/src/core/adapters/dbApi/kysely/kysely.database.ts

@@ -75,6 +75,7 @@ export type Database = {
     softwares__similar_software_external_datas: SimilarExternalSoftwareExternalDataTable;
     sources: SourcesTable;
     user_sessions: SessionsTable;
+    software_attribute_definitions: SoftwareAttributeDefinitionsTable;
 };
 
 type UsersTable = {
@@ -122,6 +123,7 @@ type InstancesTable = {
 type ExternalId = string;
 export type ExternalDataOriginKind = "wikidata" | "HAL" | "ComptoirDuLibre" | "CNLL" | "Zenodo";
 type LocalizedString = Partial<Record<string, string>>;
+export type AttributeKind = "boolean" | "string" | "number" | "date" | "url";
 
 type SimilarExternalSoftwareExternalDataTable = {
     softwareId: number;
@@ -137,6 +139,21 @@ type SourcesTable = {
     description: JSONColumnType<LocalizedString> | null;
 };
 
+type SoftwareAttributeDefinitionsTable = {
+    name: string;
+    kind: AttributeKind;
+    label: JSONColumnType<LocalizedString>;
+    description: JSONColumnType<LocalizedString> | null;
+    displayInForm: boolean;
+    displayInDetails: boolean;
+    displayInCardIcon: "computer" | "france" | "question" | "thumbs-up" | "chat" | "star" | null;
+    enableFiltering: boolean;
+    required: boolean;
+    displayOrder: number;
+    createdAt: Date;
+    updatedAt: Date;
+};
+
 export type SoftwareExternalDatasTable = {
     externalId: ExternalId;
     sourceSlug: string;
@@ -181,9 +198,7 @@ type SoftwaresTable = {
         lastRecommendedVersion?: string;
     }> | null;
     isStillInObservation: boolean;
-    doRespectRgaa: boolean | null;
-    isFromFrenchPublicService: boolean;
-    isPresentInSupportContract: boolean;
+    customAttributes: JSONColumnType<Record<string, any>> | null;
     license: string;
     softwareType: JSONColumnType<SoftwareType>;
     versionMin: string | null;

api/src/core/adapters/dbApi/kysely/migrations/1760101353900_add-custom-attributes.ts

@@ -0,0 +1,133 @@
+// SPDX-FileCopyrightText: 2021-2025 DINUM <[email protected]>
+// SPDX-FileCopyrightText: 2024-2025 Université Grenoble Alpes
+// SPDX-License-Identifier: MIT
+
+import { sql, type Kysely } from "kysely";
+
+export async function up(db: Kysely<any>): Promise<void> {
+    // Create enum type for attribute kinds
+    await db.schema.createType("attribute_kind").asEnum(["boolean", "string", "number", "date", "url"]).execute();
+    await db.schema
+        .createType("display_in_card_icon_kind")
+        .asEnum(["computer", "france", "question", "thumbs-up", "chat", "star"])
+        .execute();
+
+    // Create software_attribute_definitions table
+    await db.schema
+        .createTable("software_attribute_definitions")
+        .addColumn("name", "text", col => col.primaryKey())
+        .addColumn("kind", sql`attribute_kind`, col => col.notNull())
+        .addColumn("label", "jsonb", col => col.notNull())
+        .addColumn("description", "jsonb")
+        .addColumn("displayInForm", "boolean", col => col.notNull().defaultTo(true))
+        .addColumn("displayInDetails", "boolean", col => col.notNull().defaultTo(true))
+        .addColumn("displayInCardIcon", sql`display_in_card_icon_kind`)
+        .addColumn("enableFiltering", "boolean", col => col.notNull().defaultTo(false))
+        .addColumn("required", "boolean", col => col.notNull().defaultTo(false))
+        .addColumn("displayOrder", "integer", col => col.notNull().defaultTo(0))
+        .addColumn("createdAt", "timestamptz", col => col.notNull().defaultTo(sql`NOW()`))
+        .addColumn("updatedAt", "timestamptz", col => col.notNull().defaultTo(sql`NOW()`))
+        .execute();
+
+    // Seed existing prerogatives as attribute definitions
+    await db
+        .insertInto("software_attribute_definitions")
+        .values([
+            {
+                name: "isPresentInSupportContract",
+                kind: sql`'boolean'::attribute_kind`,
+                label: sql`'{"en": "Present in support contract", "fr": "Présent dans le marché de support"}'::jsonb`,
+                description: sql`'{"en": "The DGFIP manages two inter-ministerial markets: support (Atos) and expertise (multiple contractors) for open-source software, covering maintenance, monitoring, and expert services. https://code.gouv.fr/fr/utiliser/marches-interministeriels-support-expertise-logiciels-libres", "fr": "La DGFIP pilote deux marchés interministériels : support (Atos) et expertise (plusieurs titulaires) pour logiciels libres, couvrant maintenance, veille et prestations d’expertise. https://code.gouv.fr/fr/utiliser/marches-interministeriels-support-expertise-logiciels-libres"}'::jsonb`,
+                displayInForm: true,
+                displayInDetails: true,
+                displayInCardIcon: "question",
+                enableFiltering: true,
+                required: true,
+                displayOrder: 1
+            },
+            {
+                name: "isFromFrenchPublicService",
+                kind: sql`'boolean'::attribute_kind`,
+                label: sql`'{"en": "Software developed by French public services", "fr": "Logiciel développé par les services publics français"}'::jsonb`,
+                displayInForm: true,
+                displayInDetails: true,
+                displayInCardIcon: "france",
+                enableFiltering: true,
+                required: true,
+                displayOrder: 2
+            },
+            {
+                name: "doRespectRgaa",
+                kind: sql`'boolean'::attribute_kind`,
+                label: sql`'{"en": "RGAA compliant", "fr": "Respecte les normes RGAA"}'::jsonb`,
+                description: sql`'{"en": "Référentiel général d’amélioration de l’accessibilité. Details on : https://accessibilite.numerique.gouv.fr", "fr": "Référentiel général d’amélioration de l’accessibilité. La DINUM édite ce référentiel général d’amélioration de l’accessibilité. Détails sur : https://accessibilite.numerique.gouv.fr"}'::jsonb`,
+                displayInForm: true,
+                displayInDetails: true,
+                displayInCardIcon: null,
+                enableFiltering: true,
+                required: false,
+                displayOrder: 3
+            }
+        ])
+        .execute();
+
+    // Add customAttributes column to softwares
+    await db.schema
+        .alterTable("softwares")
+        .addColumn("customAttributes", "jsonb", col => col.notNull().defaultTo(sql`'{}'::jsonb`))
+        .execute();
+
+    // Migrate existing data to customAttributes
+    await db
+        .updateTable("softwares")
+        .set({
+            customAttributes: sql`jsonb_build_object(
+                'isPresentInSupportContract', "isPresentInSupportContract",
+                'isFromFrenchPublicService', "isFromFrenchPublicService",
+                'doRespectRgaa', "doRespectRgaa"
+            )`
+        })
+        .execute();
+
+    // Create GIN index for efficient JSONB queries
+    await sql`CREATE INDEX softwares_customAttributes_idx ON softwares USING GIN ("customAttributes")`.execute(db);
+
+    // Drop old columns
+    await db.schema
+        .alterTable("softwares")
+        .dropColumn("isPresentInSupportContract")
+        .dropColumn("isFromFrenchPublicService")
+        .dropColumn("doRespectRgaa")
+        .execute();
+}
+
+export async function down(db: Kysely<any>): Promise<void> {
+    // Restore old columns
+    await db.schema
+        .alterTable("softwares")
+        .addColumn("isPresentInSupportContract", "boolean", col => col.notNull().defaultTo(false))
+        .addColumn("isFromFrenchPublicService", "boolean", col => col.notNull().defaultTo(false))
+        .addColumn("doRespectRgaa", "boolean")
+        .execute();
+
+    // Migrate data back
+    await db
+        .updateTable("softwares")
+        .set({
+            isPresentInSupportContract: sql`COALESCE(("customAttributes"->>'isPresentInSupportContract')::boolean, false)`,
+            isFromFrenchPublicService: sql`COALESCE(("customAttributes"->>'isFromFrenchPublicService')::boolean, false)`,
+            doRespectRgaa: sql`("customAttributes"->>'doRespectRgaa')::boolean`
+        })
+        .execute();
+
+    // Drop index (by name)
+    await db.schema.dropIndex("softwares_customAttributes_idx").ifExists().execute();
+
+    // Drop customAttributes column
+    await db.schema.alterTable("softwares").dropColumn("customAttributes").execute();
+
+    // Drop tables and types
+    await db.schema.dropTable("software_attribute_definitions").execute();
+    await db.schema.dropType("attribute_kind").execute();
+    await db.schema.dropType("display_in_card_icon_kind").execute();
+}