refactor: remove useless GITHUB_TOKEN env variable

Author: JeromeBu

api/src/core/bootstrap.ts

@@ -23,7 +23,6 @@ type DbConfig = PgDbConfig;
 
 type ParamsOfBootstrapCore = {
     dbConfig: DbConfig;
-    githubPersonalAccessTokenForApiRateLimit: string;
     externalSoftwareDataOrigin: ExternalDataOrigin;
 };
 

api/src/core/updateTools.ts

@@ -17,7 +17,6 @@ type DbConfig = PgDbConfig;
 
 type ParamsOfUpdateService = {
     dbConfig: DbConfig;
-    githubPersonalAccessTokenForApiRateLimit: string;
     externalSoftwareDataOrigin: ExternalDataOrigin;
 };
 

api/src/env.ts

@@ -7,9 +7,6 @@ const zEnvConfiguration = z.object({
         "clientId": z.string().nonempty()
     }),
     "termsOfServiceUrl": zLocalizedString,
-    // Only for increasing the rate limit on GitHub API
-    // we use the GitHub API for pre filling the version when adding a software
-    "githubPersonalAccessTokenForApiRateLimit": z.string().nonempty(),
     //Port we listen to
     "port": z.coerce.number().optional().default(8080),
     "isDevEnvironnement": z.boolean().optional(),
@@ -28,7 +25,6 @@ const envConfiguration = zEnvConfiguration.parse({
         "clientId": process.env.OIDC_CLIENT_ID
     },
     "termsOfServiceUrl": process.env.TERMS_OF_SERVICE_URL,
-    "githubPersonalAccessTokenForApiRateLimit": process.env.GITHUB_TOKEN,
     "port": parseInt(process.env.API_PORT ?? ""),
     "isDevEnvironnement": process.env.IS_DEV_ENVIRONNEMENT?.toLowerCase() === "true",
     "externalSoftwareDataOrigin": process.env.EXTERNAL_SOFTWARE_DATA_ORIGIN,

api/src/rpc/createTestCaller.ts

@@ -26,7 +26,6 @@ export const createTestCaller = async ({ user }: TestCallerConfig = { user: defa
 
     const { dbApi, useCases, uiConfig } = await bootstrapCore({
         "dbConfig": { dbKind: "kysely", kyselyDb },
-        "githubPersonalAccessTokenForApiRateLimit": "fake-token",
         "externalSoftwareDataOrigin": externalSoftwareDataOrigin
     });
 

api/src/rpc/start.ts

@@ -31,7 +31,6 @@ console.info(isAssignable(translationFr) ? "isAssignable : true" : "isAssignable
 export async function startRpcService(params: {
     oidcParams: OidcParams;
     termsOfServiceUrl: LocalizedString;
-    githubPersonalAccessTokenForApiRateLimit: string;
     port: number;
     isDevEnvironnement: boolean;
     externalSoftwareDataOrigin: ExternalDataOrigin;
@@ -46,7 +45,6 @@ export async function startRpcService(params: {
         oidcParams,
         termsOfServiceUrl,
         port,
-        githubPersonalAccessTokenForApiRateLimit,
         isDevEnvironnement,
         externalSoftwareDataOrigin,
         databaseUrl,
@@ -68,8 +66,6 @@ export async function startRpcService(params: {
                 "dbKind": "kysely",
                 "kyselyDb": kyselyDb
             },
-            githubPersonalAccessTokenForApiRateLimit,
-            // "doPerPerformPeriodicalCompilation": !isDevEnvironnement && redirectUrl === undefined,
             "externalSoftwareDataOrigin": externalSoftwareDataOrigin
         }),
         createContextFactory({

api/src/rpc/update.ts

@@ -7,18 +7,11 @@ import type { ExternalDataOrigin } from "../core/ports/GetSoftwareExternalData";
 import { updateTool } from "../core/updateTools";
 
 export async function startUpdateService(params: {
-    githubPersonalAccessTokenForApiRateLimit: string;
     isDevEnvironnement: boolean;
     externalSoftwareDataOrigin: ExternalDataOrigin;
     databaseUrl: string;
 }) {
-    const {
-        githubPersonalAccessTokenForApiRateLimit,
-        isDevEnvironnement,
-        externalSoftwareDataOrigin,
-        databaseUrl,
-        ...rest
-    } = params;
+    const { isDevEnvironnement, externalSoftwareDataOrigin, databaseUrl, ...rest } = params;
 
     assert<Equals<typeof rest, {}>>();
 
@@ -31,7 +24,6 @@ export async function startUpdateService(params: {
             "dbKind": "kysely",
             "kyselyDb": kyselyDb
         },
-        githubPersonalAccessTokenForApiRateLimit,
         "externalSoftwareDataOrigin": externalSoftwareDataOrigin
     });
 

docs/deploying-the-web-app-bare-metal.md

@@ -54,7 +54,6 @@ Create a `.env` file with a content like this
 OIDC_ISSUER_URI=http://localhost:8081/auth/realms/codegouv
 OIDC_CLIENT_ID=sill
 TERMS_OF_SERVICE_URL=https://code.gouv.fr/sill/tos_fr.md
-GITHUB_TOKEN=ghp_xxxxxx
 API_PORT=3084
 IS_DEV_ENVIRONNEMENT=true
 DATABASE_URL=postgresql://sill:pg_password@localhost:5432/sill

docs/deploying.md

@@ -376,7 +376,6 @@ SSH_PRIVATE_KEY="-----BEGIN OPENSSH PRIVATE KEY-----\nxxxx\nxxxx\nxxxx\nAxxxx\nx
 DATA_REPO_SSH_URL="[email protected]:codegouvfr/sill-data.git" # Replace by the repo you created earlyer
 KEYCLOAK_PASSWORD=yyyyyy # Make sure it's the same that the one you defined earlyer
 WEBHOOK_SECRET=dSdSPxxxxxx # (optional) Some random caracters 
-GITHUB_TOKEN=ghp_xxxxxx # A token, just for the GitHub API rate limit.  
 SOFTWARE_DATA_ORIGIN=wikidata # Can be "wikidata" or "HAL" (See: https://hal.science/)
 
 WEB_VERSION="1.41.2" # To keep up to date with https://github.com/codegouvfr/sill-web/releases/
@@ -433,7 +432,6 @@ api:
         "sshPrivateKeyForGitName": "$SSH_PRIVATE_KEY_NAME",
         "sshPrivateKeyForGit": "$SSH_PRIVATE_KEY",
         "githubWebhookSecret": "$WEBHOOK_SECRET",
-        "githubPersonalAccessTokenForApiRateLimit": "$GITHUB_TOKEN",
         "externalSoftwareDataOrigin": "$SOFTWARE_DATA_ORIGIN"
       }
 

docs/setting-up-a-development-environment.md

@@ -27,7 +27,6 @@ Makes sure to put the name of your SSH key and the private key (generated when y
 OIDC_ISSUER_URI=http://localhost:8081/auth/realms/codegouv
 OIDC_CLIENT_ID=sill
 TERMS_OF_SERVICE_URL=https://code.gouv.fr/sill/tos_fr.md
-GITHUB_TOKEN=ghp_xxxxxx
 API_PORT=3084
 IS_DEV_ENVIRONNEMENT=true
 DATABASE_URL=postgresql://sill:pg_password@localhost:5432/sill