Updated to stop failing creating 'Created-by' manifest entries,

when the version of the archiver cannot be determined.

This closes #43

Author: ChristianSchulte

src/main/java/org/codehaus/plexus/archiver/jar/JdkManifestFactory.java

@@ -33,33 +33,42 @@ class JdkManifestFactory
     public static java.util.jar.Manifest getDefaultManifest()
         throws ArchiverException
     {
-        try
+        final java.util.jar.Manifest defaultManifest = new java.util.jar.Manifest();
+        defaultManifest.getMainAttributes().putValue( "Manifest-Version", "1.0" );
+
+        String createdBy = "Plexus Archiver";
+
+        final String plexusArchiverVersion = getArchiverVersion();
+
+        if ( plexusArchiverVersion != null )
         {
-            final java.util.jar.Manifest defaultManifest = new java.util.jar.Manifest();
-            defaultManifest.getMainAttributes().putValue( "Manifest-Version", "1.0" );
+            createdBy += " " + plexusArchiverVersion;
+        }
+
+        defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
+        return defaultManifest;
+    }
 
-            String createdBy = "Plexus Archiver";
+    private static String getArchiverVersion()
+    {
+        String version = null;
 
+        try
+        {
             final Properties properties = PropertyUtils.loadProperties( JdkManifestFactory.class.getResourceAsStream(
                 "/META-INF/maven/org.codehaus.plexus/plexus-archiver/pom.properties" ) );
 
             if ( properties != null )
             {
-                String plexusArchiverVersion = properties.getProperty( "version" );
-                if ( plexusArchiverVersion != null )
-                {
-                    createdBy += " " + plexusArchiverVersion;
-                }
+                version = properties.getProperty( "version" );
             }
-
-            defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
-
-            return defaultManifest;
         }
         catch ( final IOException e )
         {
-            throw new ArchiverException( "Failure reading default manifest.", e );
+            version = null;
         }
+
+        return version;
     }
 
     public static void merge( java.util.jar.Manifest target, java.util.jar.Manifest other, boolean overwriteMain )
@@ -113,5 +122,4 @@ public static void mergeAttributes( java.util.jar.Attributes target, java.util.j
         }
     }
 
-
 }

src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java

@@ -735,32 +735,43 @@ public Iterator<String> iterator()
     public static Manifest getDefaultManifest()
         throws ArchiverException
     {
-        try
+        final Manifest defaultManifest = new Manifest();
+        defaultManifest.getMainAttributes().putValue( "Manifest-Version", "1.0" );
+
+        String createdBy = "Plexus Archiver";
+
+        final String plexusArchiverVersion = getArchiverVersion();
+
+        if ( plexusArchiverVersion != null )
         {
-            final Manifest defaultManifest = new Manifest();
-            defaultManifest.getMainAttributes().putValue( "Manifest-Version", "1.0" );
+            createdBy += " " + plexusArchiverVersion;
+        }
+
+        defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
 
-            String createdBy = "Plexus Archiver";
+        return defaultManifest;
+    }
 
-            final Properties properties = PropertyUtils.loadProperties( Manifest.class.getResourceAsStream(
+    private static String getArchiverVersion()
+    {
+        String version = null;
+
+        try
+        {
+            final Properties properties = PropertyUtils.loadProperties( JdkManifestFactory.class.getResourceAsStream(
                 "/META-INF/maven/org.codehaus.plexus/plexus-archiver/pom.properties" ) );
 
             if ( properties != null )
             {
-                String plexusArchiverVersion = properties.getProperty( "version" );
-                if ( plexusArchiverVersion != null )
-                {
-                    createdBy += " " + plexusArchiverVersion;
-                }
+                version = properties.getProperty( "version" );
             }
-            defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
-
-            return defaultManifest;
         }
         catch ( final IOException e )
         {
-            throw new ArchiverException( "Failure reading default manifest.", e );
+            version = null;
         }
+
+        return version;
     }
 
     /**