PLXCOMP-220: added unit tests for handling invalid uid/gid in TarEntry

Author: sergei-ivanov

src/test/java/org/codehaus/plexus/archiver/tar/PosixTarEntryTest.java

@@ -30,7 +30,7 @@ public void testFileConstructor()
         new PosixTarEntry( new java.io.File( "/foo" ) );
     }
 
-    public void testPathSplittig()
+    public void testPathSplitting()
     {
     	PosixTarEntry pte = new PosixTarEntry( "/a/very/long/path/to/file/but/not/too/long/so/it/does/not/exceed/TarConstants.NAMELEN/plus/TarConstants.POSIX_PREFIXLEN" );
     	assertEquals("/a/very/long/path/to", pte.prefix.toString());
@@ -44,4 +44,20 @@ public void testPathSplittig()
     	assertEquals("", pte.prefix.toString());
     	assertEquals("this/path/has/exactly/99/characters/one/two/three/four/five/six/seven/eight/nine/ten/eleven/twelve/", pte.name.toString());
     }
+
+    /**
+     * Test case for PLXCOMP-220.
+     */
+    public void testInvalidUidGid()
+    {
+        final TarEntry writtenEntry = new TarEntry( "test.java" );
+        writtenEntry.setUserId( -1 );
+        writtenEntry.setGroupId( -1 );
+        final byte[] buffer = new byte[TarBuffer.DEFAULT_RCDSIZE];
+        writtenEntry.writeEntryHeader( buffer );
+
+        final TarEntry readEntry = new TarEntry( buffer );
+        assertEquals( 0, readEntry.getUserId() );
+        assertEquals( 0, readEntry.getGroupId() );
+    }
 }

src/test/java/org/codehaus/plexus/archiver/tar/TarEntryTest.java

@@ -27,11 +27,28 @@
 public class TarEntryTest
     extends TestCase
 {
+
     /**
      * demonstrates bug 18105 on OSes with os.name shorter than 7.
      */
     public void testFileConstructor()
     {
         new TarEntry( new java.io.File( "/foo" ) );
     }
+
+    /**
+     * Test case for PLXCOMP-220.
+     */
+    public void testInvalidUidGid()
+    {
+        final TarEntry writtenEntry = new TarEntry( "test.java" );
+        writtenEntry.setUserId( -1 );
+        writtenEntry.setGroupId( -1 );
+        final byte[] buffer = new byte[TarBuffer.DEFAULT_RCDSIZE];
+        writtenEntry.writeEntryHeader( buffer );
+
+        final TarEntry readEntry = new TarEntry( buffer );
+        assertEquals( 0, readEntry.getUserId() );
+        assertEquals( 0, readEntry.getGroupId() );
+    }
 }