Skip to content

Commit 5bb0adb

Browse files
author
Vlad Tatavu
committed
MNGECLIPSE-1469: error markers are not created for maven build errors
git-svn-id: file:///opt/svn/repositories/sonatype.org/spice/trunk/plexus-build-api@2988 5751e0cb-dcb7-432f-92e2-260806df54be
1 parent 7aefb56 commit 5bb0adb

File tree

4 files changed

+38
-11
lines changed

4 files changed

+38
-11
lines changed

src/main/java/org/sonatype/plexus/build/incremental/BuildContext.java

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public interface BuildContext {
3737
* Returns <code>true</code> if the file has changed since last build or is not
3838
* under basedir.
3939
*
40-
* @since 0.5.0
40+
* @since 0.0.5
4141
*/
4242
boolean hasDelta(File file);
4343

@@ -144,26 +144,33 @@ public interface BuildContext {
144144
Object getValue(String key);
145145

146146
/**
147-
*
148-
* @since 0.5.0
147+
* @since 0.0.5
149148
*/
150149
void addWarning(File file, int line, int column, String message, Throwable cause);
151150

152151
/**
153-
*
154-
* @since 0.5.0
152+
* @since 0.0.7
153+
*/
154+
void removeWarnings(File file);
155+
156+
/**
157+
* @since 0.0.5
155158
*/
156159
void addError(File file, int line, int column, String message, Throwable cause);
157160

161+
/**
162+
* @since 0.0.7
163+
*/
164+
void removeErrors(File file);
165+
158166
/**
159167
* Returns true, if the target file exists and is uptodate compared to the source file.
160168
*
161169
* More specifically, this method returns true when both target and source files exist,
162170
* do not have changes since last incremental build and the target file was last modified
163171
* later than the source file. Returns false in all other cases.
164172
*
165-
* @since 0.5.0
173+
* @since 0.0.5
166174
*/
167175
boolean isUptodate(File target, File source);
168-
169176
}

src/main/java/org/sonatype/plexus/build/incremental/DefaultBuildContext.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@ public Object getValue(String key) {
8383
public void setValue(String key, Object value) {
8484
}
8585

86-
public void addWarning(File file, int line, int column, String message, Throwable cause) {
87-
getLogger().warn(getMessage(file, line, column, message), cause);
88-
}
89-
9086
private String getMessage(File file, int line, int column, String message) {
9187
StringBuffer sb = new StringBuffer();
9288
sb.append(file.getAbsolutePath()).append(" [").append(line).append(':').append(column).append("]: ");
@@ -98,8 +94,18 @@ public void addError(File file, int line, int column, String message, Throwable
9894
getLogger().error(getMessage(file, line, column, message), cause);
9995
}
10096

97+
public void addWarning(File file, int line, int column, String message, Throwable cause) {
98+
getLogger().warn(getMessage(file, line, column, message), cause);
99+
}
100+
101101
public boolean isUptodate(File target, File source) {
102102
return target != null && target.exists() && source != null && source.exists()
103103
&& target.lastModified() > source.lastModified();
104104
}
105+
106+
public void removeWarnings(File file) {
107+
}
108+
109+
public void removeErrors(File file) {
110+
}
105111
}

src/main/java/org/sonatype/plexus/build/incremental/ThreadBuildContext.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,14 @@ public void setValue(String key, Object value) {
9191
getContext().setValue(key, value);
9292
}
9393

94+
public void removeWarnings(File file) {
95+
getContext().removeWarnings(file);
96+
}
97+
98+
public void removeErrors(File file) {
99+
getContext().removeErrors(file);
100+
}
101+
94102
public void addWarning(File file, int line, int column, String message, Throwable cause) {
95103
getContext().addWarning(file, line, column, message, cause);
96104
}

src/test/java/org/sonatype/plexus/build/incremental/test/TestIncrementalBuildContext.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,12 @@ public void addError(File file, int line, int column, String message, Throwable
184184
public void addWarning(File file, int line, int column, String message, Throwable cause) {
185185
}
186186

187+
public void removeWarnings(File file) {
188+
}
189+
190+
public void removeErrors(File file) {
191+
}
192+
187193
public boolean isUptodate(File target, File source) {
188194
return target != null && target.exists() && !hasDelta(target)
189195
&& source != null && source.exists() && !hasDelta(source)

0 commit comments

Comments
 (0)