Skip to content

Commit 738c950

Browse files
Copilotlaeubi
andcommitted
Fix log message formatting and clarify INFO mapping
Co-authored-by: laeubi <[email protected]>
1 parent b17ea7c commit 738c950

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,18 @@ private String formatLogMessage(Message message) {
128128
sb.append(message.getPath().toAbsolutePath());
129129
}
130130

131-
if (message.getLine() > 0 || message.getColumn() > 0) {
131+
if (message.getLine() > 0 && message.getColumn() > 0) {
132132
sb.append(" [");
133-
if (message.getLine() > 0) {
134-
sb.append(message.getLine());
135-
}
136-
if (message.getColumn() > 0) {
137-
sb.append(':').append(message.getColumn());
138-
}
133+
sb.append(message.getLine());
134+
sb.append(':').append(message.getColumn());
135+
sb.append("]");
136+
} else if (message.getLine() > 0) {
137+
sb.append(" [");
138+
sb.append(message.getLine());
139+
sb.append("]");
140+
} else if (message.getColumn() > 0) {
141+
sb.append(" [:");
142+
sb.append(message.getColumn());
139143
sb.append("]");
140144
}
141145

@@ -163,7 +167,9 @@ private int mapTypeToSeverity(MessageType type) {
163167
return BuildContext.SEVERITY_WARNING;
164168
case INFO:
165169
default:
166-
// There's no INFO severity in BuildContext, use WARNING as fallback
170+
// There's no INFO severity in BuildContext (only WARNING and ERROR),
171+
// so we map INFO messages to WARNING to ensure they are still visible in the IDE.
172+
// Custom implementations may provide different mappings.
167173
return BuildContext.SEVERITY_WARNING;
168174
}
169175
}

0 commit comments

Comments
 (0)