JUnit Jupiter best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.junit.JupiterBestPractices?organizationId=NzQ1YmJlODUtZjNkMy00OTNkLThhNDAtZWJmZDg4N2U1ZjU1

Co-authored-by: Moderne <[email protected]>

Author: slachiewicz

src/test/java/org/codehaus/plexus/classworlds/ClassWorldTest.java

@@ -36,36 +36,36 @@ class ClassWorldTest extends AbstractClassWorldsTestCase {
     private ClassWorld world;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         this.world = new ClassWorld();
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         this.world = null;
     }
 
     @Test
-    void testEmpty() {
+    void empty() {
         assertTrue(this.world.getRealms().isEmpty());
     }
 
     @Test
-    void testNewRealm() throws Exception {
+    void newRealm() throws Exception {
         ClassRealm realm = this.world.newRealm("foo");
 
         assertNotNull(realm);
     }
 
     @Test
-    void testGetRealm() throws Exception {
+    void getRealm() throws Exception {
         ClassRealm realm = this.world.newRealm("foo");
 
         assertSame(realm, this.world.getRealm("foo"));
     }
 
     @Test
-    void testNewRealm_Duplicate() {
+    void newRealmDuplicate() {
         try {
             this.world.newRealm("foo");
             this.world.newRealm("foo");
@@ -81,7 +81,7 @@ void testNewRealm_Duplicate() {
     }
 
     @Test
-    void testGetRealm_NoSuch() {
+    void getRealmNoSuch() {
         try {
             this.world.getRealm("foo");
             fail("throw NoSuchRealmException");
@@ -95,7 +95,7 @@ void testGetRealm_NoSuch() {
     }
 
     @Test
-    void testGetRealms() throws Exception {
+    void getRealms() throws Exception {
         assertTrue(this.world.getRealms().isEmpty());
 
         ClassRealm foo = this.world.newRealm("foo");
@@ -112,7 +112,7 @@ void testGetRealms() throws Exception {
     }
 
     @Test
-    void testPLX334() throws Exception {
+    void plx334() throws Exception {
         ClassLoader loader = new URLClassLoader(new URL[] {getJarUrl("component1-1.0.jar")});
         world.newRealm("netbeans", loader);
         ClassRealm plexus = world.newRealm("plexus");

src/test/java/org/codehaus/plexus/classworlds/UrlUtilsTest.java

@@ -23,7 +23,7 @@
 class UrlUtilsTest {
 
     @Test
-    public void testNormalizeUrlPath() {
+    void normalizeUrlPath() {
         assertEquals("org/codehaus/Test.class", UrlUtils.normalizeUrlPath("org/codehaus/Test.class"));
         assertEquals("org/Test.class", UrlUtils.normalizeUrlPath("org/codehaus/../Test.class"));
         assertEquals("../../some.jar/org/Test.class", UrlUtils.normalizeUrlPath("../../some.jar/org/Test.class"));

src/test/java/org/codehaus/plexus/classworlds/launcher/ConfigurationParserTest.java

@@ -12,7 +12,7 @@ class ConfigurationParserTest extends AbstractClassWorldsTestCase {
     final ConfigurationParser configurator = new ConfigurationParser(null, System.getProperties());
 
     @Test
-    void testFilter_Unterminated() {
+    void filterUnterminated() {
         try {
             this.configurator.filter("${cheese");
             fail("throw ConfigurationException");
@@ -23,7 +23,7 @@ void testFilter_Unterminated() {
     }
 
     @Test
-    void testFilter_Solitary() throws Exception {
+    void filterSolitary() throws Exception {
         System.setProperty("classworlds.test.prop", "test prop value");
 
         String result = this.configurator.filter("${classworlds.test.prop}");
@@ -32,7 +32,7 @@ void testFilter_Solitary() throws Exception {
     }
 
     @Test
-    void testFilter_AtStart() throws Exception {
+    void filterAtStart() throws Exception {
         System.setProperty("classworlds.test.prop", "test prop value");
 
         String result = this.configurator.filter("${classworlds.test.prop}cheese");
@@ -41,7 +41,7 @@ void testFilter_AtStart() throws Exception {
     }
 
     @Test
-    void testFilter_AtEnd() throws Exception {
+    void filterAtEnd() throws Exception {
         System.setProperty("classworlds.test.prop", "test prop value");
 
         String result = this.configurator.filter("cheese${classworlds.test.prop}");
@@ -50,7 +50,7 @@ void testFilter_AtEnd() throws Exception {
     }
 
     @Test
-    void testFilter_Multiple() throws Exception {
+    void filterMultiple() throws Exception {
         System.setProperty("classworlds.test.prop.one", "test prop value one");
 
         System.setProperty("classworlds.test.prop.two", "test prop value two");
@@ -62,7 +62,7 @@ void testFilter_Multiple() throws Exception {
     }
 
     @Test
-    void testFilter_NonExistent() {
+    void filterNonExistent() {
         try {
             this.configurator.filter("${gollygeewillikers}");
             fail("throw ConfigurationException");
@@ -73,7 +73,7 @@ void testFilter_NonExistent() {
     }
 
     @Test
-    void testFilter_InMiddle() throws Exception {
+    void filterInMiddle() throws Exception {
         System.setProperty("classworlds.test.prop", "test prop value");
 
         String result = this.configurator.filter("cheese${classworlds.test.prop}toast");

src/test/java/org/codehaus/plexus/classworlds/launcher/ConfiguratorTest.java

@@ -42,13 +42,13 @@ class ConfiguratorTest extends AbstractClassWorldsTestCase {
     private Configurator configurator;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         this.launcher = new Launcher();
         this.configurator = new Configurator(this.launcher);
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         this.launcher = null;
         this.configurator = null;
         System.getProperties().remove("set.using.existent");
@@ -60,7 +60,7 @@ public void tearDown() {
     }
 
     @Test
-    void testConfigure_Nonexistent() throws Exception {
+    void configureNonexistent() throws Exception {
         try {
             this.configurator.configure(getConfigPath("notfound.conf"));
             fail("throw FileNotFoundException");
@@ -70,7 +70,7 @@ void testConfigure_Nonexistent() throws Exception {
     }
 
     @Test
-    void testConfigure_DuplicateMain() throws Exception {
+    void configureDuplicateMain() throws Exception {
         try {
             this.configurator.configure(getConfigPath("dupe-main.conf"));
             fail("throw ConfigurationException");
@@ -81,7 +81,7 @@ void testConfigure_DuplicateMain() throws Exception {
     }
 
     @Test
-    void testConfigure_DuplicateRealm() throws Exception {
+    void configureDuplicateRealm() throws Exception {
         try {
             this.configurator.configure(getConfigPath("dupe-realm.conf"));
             fail("throw DuplicateRealmException");
@@ -92,7 +92,7 @@ void testConfigure_DuplicateRealm() throws Exception {
     }
 
     @Test
-    void testConfigure_EarlyImport() throws Exception {
+    void configureEarlyImport() throws Exception {
         try {
             this.configurator.configure(getConfigPath("early-import.conf"));
             fail("throw ConfigurationException");
@@ -103,7 +103,7 @@ void testConfigure_EarlyImport() throws Exception {
     }
 
     @Test
-    void testConfigure_RealmSyntax() throws Exception {
+    void configureRealmSyntax() throws Exception {
         try {
             this.configurator.configure(getConfigPath("realm-syntax.conf"));
             fail("throw ConfigurationException");
@@ -114,7 +114,7 @@ void testConfigure_RealmSyntax() throws Exception {
     }
 
     @Test
-    void testConfigure_Valid() throws Exception {
+    void configureValid() throws Exception {
         this.configurator.configure(getConfigPath("valid.conf"));
 
         assertEquals("org.apache.maven.app.App", this.launcher.getMainClassName());
@@ -161,7 +161,7 @@ void testConfigure_Valid() throws Exception {
     }
 
     @Test
-    void testConfigure_Optionally_NonExistent() throws Exception {
+    void configureOptionallyNonExistent() throws Exception {
         this.configurator.configure(getConfigPath("optionally-nonexistent.conf"));
 
         assertEquals("org.apache.maven.app.App", this.launcher.getMainClassName());
@@ -184,7 +184,7 @@ void testConfigure_Optionally_NonExistent() throws Exception {
     }
 
     @Test
-    void testConfigure_Optionally_Existent() throws Exception {
+    void configureOptionallyExistent() throws Exception {
         this.configurator.configure(getConfigPath("optionally-existent.conf"));
 
         assertEquals("org.apache.maven.app.App", this.launcher.getMainClassName());
@@ -209,7 +209,7 @@ void testConfigure_Optionally_Existent() throws Exception {
     }
 
     @Test
-    void testConfigure_Unhandled() throws Exception {
+    void configureUnhandled() throws Exception {
         try {
             this.configurator.configure(getConfigPath("unhandled.conf"));
             fail("throw ConfigurationException");
@@ -220,7 +220,7 @@ void testConfigure_Unhandled() throws Exception {
     }
 
     @Test
-    void testSet_Using_Existent() throws Exception {
+    void setUsingExistent() throws Exception {
         assertNull(System.getProperty("set.using.existent"));
 
         this.configurator.configure(getConfigPath("set-using-existent.conf"));
@@ -229,7 +229,7 @@ void testSet_Using_Existent() throws Exception {
     }
 
     @Test
-    void testSet_Using_NonExistent() throws Exception {
+    void setUsingNonExistent() throws Exception {
         assertNull(System.getProperty("set.using.nonexistent"));
 
         this.configurator.configure(getConfigPath("set-using-nonexistent.conf"));
@@ -238,7 +238,7 @@ void testSet_Using_NonExistent() throws Exception {
     }
 
     @Test
-    void testSet_Using_NonExistent_Default() throws Exception {
+    void setUsingNonExistentDefault() throws Exception {
         assertNull(System.getProperty("set.using.nonexistent.default"));
 
         this.configurator.configure(getConfigPath("set-using-nonexistent.conf"));
@@ -247,7 +247,7 @@ void testSet_Using_NonExistent_Default() throws Exception {
     }
 
     @Test
-    void testSet_Using_NonExistent_Override() throws Exception {
+    void setUsingNonExistentOverride() throws Exception {
         assertNull(System.getProperty("set.using.default"));
         System.setProperty("set.using.default", "testSet_Using_NonExistent_Override");
 
@@ -257,7 +257,7 @@ void testSet_Using_NonExistent_Override() throws Exception {
     }
 
     @Test
-    void testSet_Using_Existent_Override() throws Exception {
+    void setUsingExistentOverride() throws Exception {
         assertNull(System.getProperty("set.using.existent"));
         System.setProperty("set.using.existent", "testSet_Using_Existent_Override");
 
@@ -267,7 +267,7 @@ void testSet_Using_Existent_Override() throws Exception {
     }
 
     @Test
-    void testSet_Using_Existent_Default() throws Exception {
+    void setUsingExistentDefault() throws Exception {
         assertNull(System.getProperty("set.using.default"));
 
         this.configurator.configure(getConfigPath("set-using-existent.conf"));
@@ -276,7 +276,7 @@ void testSet_Using_Existent_Default() throws Exception {
     }
 
     @Test
-    void testSet_Using_Missing_Default() throws Exception {
+    void setUsingMissingDefault() throws Exception {
         assertNull(System.getProperty("set.using.missing"));
 
         this.configurator.configure(getConfigPath("set-using-missing.conf"));
@@ -285,7 +285,7 @@ void testSet_Using_Missing_Default() throws Exception {
     }
 
     @Test
-    void testSet_Using_Missing_Override() throws Exception {
+    void setUsingMissingOverride() throws Exception {
         assertNull(System.getProperty("set.using.missing"));
         System.setProperty("set.using.missing", "testSet_Using_Missing_Override");
 
@@ -295,7 +295,7 @@ void testSet_Using_Missing_Override() throws Exception {
     }
 
     @Test
-    void testSet_Using_Filtered_Default() throws Exception {
+    void setUsingFilteredDefault() throws Exception {
         assertNull(System.getProperty("set.using.filtered.default"));
 
         this.configurator.configure(getConfigPath("set-using-missing.conf"));
@@ -305,7 +305,7 @@ void testSet_Using_Filtered_Default() throws Exception {
 
     @SuppressWarnings("OptionalGetWithoutIsPresent")
     @Test
-    void testFromFromFrom() throws Exception {
+    void fromFromFrom() throws Exception {
         this.configurator.configure(getConfigPath("valid-from-from-from.conf"));
 
         assertEquals("com.from.from.from.Main", this.launcher.getMainClassName());