JUnit Jupiter best practices (#32)

Co-authored-by: Moderne <[email protected]>

Author: slachiewicz

src/test/java/org/codehaus/plexus/i18n/DefaultI18NTest.java

@@ -73,7 +73,7 @@
  * @author <a href="mailto:[email protected]">Jason van Zyl</a>
  */
 @PlexusTest
-public class DefaultI18NTest {
+class DefaultI18NTest {
     @Inject
     private I18N i18n;
 
@@ -84,7 +84,7 @@ protected void setUp() {
     }
 
     @Test
-    public void testLocalization() {
+    void localization() {
         String s0 = i18n.getString(null, null, "key1");
         assertEquals("[] value1", s0, "Unable to retrieve localized text for locale: default");
 
@@ -121,7 +121,7 @@ public void testLocalization() {
     }
 
     @Test
-    public void testLocalizedMessagesWithFormatting() {
+    void localizedMessagesWithFormatting() {
         // Format methods
 
         String s6 = i18n.format("org.codehaus.plexus.i18n.i18n", null, "thanks.message", "jason");
@@ -137,13 +137,13 @@ public void testLocalizedMessagesWithFormatting() {
     }
 
     @Test
-    public void testLocalizedMessagesWithNonStandardLocale() {
+    void localizedMessagesWithNonStandardLocale() {
         String s0 = i18n.getString("name", new Locale("xx"));
         assertEquals("plexus", s0);
     }
 
     @Test
-    public void testNoFallbackToDefaultLocale() {
+    void noFallbackToDefaultLocale() {
         // Save the current default locale
         Locale oldDefault = Locale.getDefault();
 

src/test/java/org/codehaus/plexus/i18n/I18NTokenizerTest.java

@@ -67,9 +67,9 @@
  * @author <a href="mailto:[email protected]">Jason van Zyl</a>
  * @version $Id: I18NTokenizerTest.java 831 2004-06-16 17:01:12Z jvanzyl $
  */
-public class I18NTokenizerTest {
+class I18NTokenizerTest {
     @Test
-    public void testLocaleTokenizer() {
+    void localeTokenizer() {
         I18NTokenizer tok = new I18NTokenizer("en, es;q=0.8, zh-TW;q=0.1");
         Locale locale = tok.next();
         assertEquals("en", locale.getLanguage(), "Either wrong language or order parsing: " + locale);