Improve legacy report

Author: cstamas

src/main/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcher.java

@@ -213,12 +213,12 @@ public ValidationResponse validateConfiguration() {
                             report.computeIfAbsent(ValidationResponse.Level.INFO, k -> new ArrayList<>())
                                     .add("Default dispatcher " + defaultDispatcher + " configuration is valid");
 
+                            // below is legacy check, that does not affect validity of config, is merely informational
                             Dispatcher legacy = dispatchers.get(LegacyDispatcher.NAME);
                             if (legacy == null) {
                                 report.computeIfAbsent(ValidationResponse.Level.INFO, k -> new ArrayList<>())
                                         .add("Legacy dispatcher not present in system");
                             } else {
-                                // legacy is just "informational" does not affect overall status; merely allows fallback
                                 report.computeIfAbsent(ValidationResponse.Level.INFO, k -> new ArrayList<>())
                                         .add("Legacy dispatcher present in system");
                                 ValidationResponse legacyResponse =

src/main/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcher.java

@@ -111,18 +111,27 @@ public SecDispatcher.ValidationResponse validateConfiguration(Map<String, String
         HashMap<SecDispatcher.ValidationResponse.Level, List<String>> report = new HashMap<>();
         boolean valid = false;
         try {
-            String mp = getMasterPassword();
-            if (mp == null) {
+            String mpe = getMasterMasterPasswordFromSettingsSecurityXml();
+            if (mpe == null) {
                 report.computeIfAbsent(SecDispatcher.ValidationResponse.Level.ERROR, k -> new ArrayList<>())
-                        .add("Master Password not found");
+                        .add("Legacy configuration not found or does not contain encrypted master password");
             } else {
                 report.computeIfAbsent(SecDispatcher.ValidationResponse.Level.INFO, k -> new ArrayList<>())
-                        .add("Master Password found and decrypted");
-                valid = true;
+                        .add("Legacy configuration found and contain encrypted master password");
+
+                String mp = getMasterPassword();
+                if (mp == null) {
+                    report.computeIfAbsent(SecDispatcher.ValidationResponse.Level.ERROR, k -> new ArrayList<>())
+                            .add("Master Password not found");
+                } else {
+                    report.computeIfAbsent(SecDispatcher.ValidationResponse.Level.INFO, k -> new ArrayList<>())
+                            .add("Master Password successfully decrypted");
+                    valid = true;
+                }
             }
         } catch (PlexusCipherException e) {
             report.computeIfAbsent(SecDispatcher.ValidationResponse.Level.ERROR, k -> new ArrayList<>())
-                    .add("Master Password could not be decrypted");
+                    .add("Master Password decryption failed");
         }
         return new SecDispatcher.ValidationResponse(getClass().getSimpleName(), valid, report, List.of());
     }