Skip to content

Commit f943fb0

Browse files
committed
fix BareExcept
1 parent 866b558 commit f943fb0

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/easy_sqlite3/bindings.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,6 @@ proc execM*(db: var Database, sqls: varargs[string]) {.discardable.} =
559559
for sql in sqls:
560560
discard db.exec(sql, cache = false)
561561
discard db.exec "COMMIT"
562-
except:
562+
except CatchableError:
563563
discard db.exec "ROLLBACK"
564564
raise getCurrentException()

src/easy_sqlite3/macros.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ template gen_transaction(db: var Database, begin_stmt, body: untyped): untyped =
290290
try:
291291
body
292292
commit()
293-
except:
293+
except CatchableError:
294294
db_rollback db
295295
raise getCurrentException()
296296

tests/test_catch.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ suite "catch":
1717
try:
1818
discard db.insertData(1, 2)
1919
fail()
20-
except:
20+
except CatchableError:
2121
check getCurrentExceptionMsg() == "UNIQUE constraint failed: data.id"
2222
test "get data":
2323
check db.getData(1) == (value: 1)

tests/test_thread.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ else:
1616
try:
1717
body
1818
break
19-
except:
19+
except CatchableError:
2020
failed.inc
2121
if failed > 0:
2222
failedCount.atomicInc(failed)

0 commit comments

Comments
 (0)