refactor: add @throws RedirectException in Controller::initController()

paulbalandan · paulbalandan · commit 0652f2a0777b · 2024-12-16T19:40:12.000+08:00
diff --git a/system/Controller.php b/system/Controller.php
@@ -15,6 +15,7 @@
 
 use CodeIgniter\HTTP\CLIRequest;
 use CodeIgniter\HTTP\Exceptions\HTTPException;
+use CodeIgniter\HTTP\Exceptions\RedirectException;
 use CodeIgniter\HTTP\IncomingRequest;
 use CodeIgniter\HTTP\RequestInterface;
 use CodeIgniter\HTTP\ResponseInterface;
@@ -78,6 +79,7 @@ class Controller
      * @return void
      *
      * @throws HTTPException
+     * @throws RedirectException
      */
     public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)
     {
@@ -106,6 +108,7 @@ public function initController(RequestInterface $request, ResponseInterface $res
      * @return void
      *
      * @throws HTTPException
+     * @throws RedirectException
      */
     protected function forceHTTPS(int $duration = 31_536_000)
     {
diff --git a/utils/phpstan-baseline/catch.neverThrown.neon b/utils/phpstan-baseline/catch.neverThrown.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -7,7 +7,6 @@ includes:
     - booleanNot.exprNotBoolean.neon
     - booleanOr.leftNotBoolean.neon
     - booleanOr.rightNotBoolean.neon
-    - catch.neverThrown.neon
     - class.notFound.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`
`16`	`16`	`use CodeIgniter\HTTP\CLIRequest;`
`17`	`17`	`use CodeIgniter\HTTP\Exceptions\HTTPException;`
	`18`	`+use CodeIgniter\HTTP\Exceptions\RedirectException;`
`18`	`19`	`use CodeIgniter\HTTP\IncomingRequest;`
`19`	`20`	`use CodeIgniter\HTTP\RequestInterface;`
`20`	`21`	`use CodeIgniter\HTTP\ResponseInterface;`
`@@ -78,6 +79,7 @@ class Controller`
`78`	`79`	`* @return void`
`79`	`80`	`*`
`80`	`81`	`* @throws HTTPException`
	`82`	`+ * @throws RedirectException`
`81`	`83`	`*/`
`82`	`84`	`public function initController(RequestInterface $request, ResponseInterface $response, LoggerInterface $logger)`
`83`	`85`	`{`
`@@ -106,6 +108,7 @@ public function initController(RequestInterface $request, ResponseInterface $res`
`106`	`108`	`* @return void`
`107`	`109`	`*`
`108`	`110`	`* @throws HTTPException`
	`111`	`+ * @throws RedirectException`
`109`	`112`	`*/`
`110`	`113`	`protected function forceHTTPS(int $duration = 31_536_000)`
`111`	`114`	`{`