Fix impossible conditional in test

paulbalandan · paulbalandan · commit 0e999fc76e87 · 2025-01-17T18:35:35.000+08:00
diff --git a/tests/system/Cache/CacheFactoryTest.php b/tests/system/Cache/CacheFactoryTest.php
@@ -96,8 +96,8 @@ public function testHandlesBadHandler(): void
 
         $this->config->handler = 'dummy';
 
-        if (str_starts_with('win', strtolower(php_uname()))) {
-            $this->assertTrue(true); // can't test properly if we are on Windows
+        if (is_windows()) {
+            $this->markTestSkipped('Cannot test this properly on Windows.');
         } else {
             $this->assertInstanceOf(DummyHandler::class, $this->cacheFactory->getHandler($this->config, 'wincache', 'wincache'));
         }

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ public function testHandlesBadHandler(): void`
`96`	`96`
`97`	`97`	`$this->config->handler = 'dummy';`
`98`	`98`
`99`		`- if (str_starts_with('win', strtolower(php_uname()))) {`
`100`		`- $this->assertTrue(true); // can't test properly if we are on Windows`
	`99`	`+ if (is_windows()) {`
	`100`	`+ $this->markTestSkipped('Cannot test this properly on Windows.');`
`101`	`101`	`} else {`
`102`	`102`	`$this->assertInstanceOf(DummyHandler::class, $this->cacheFactory->getHandler($this->config, 'wincache', 'wincache'));`
`103`	`103`	`}`