refactor: using property promotion on ResponseTraitTest

Author: samsonasik

tests/system/API/ResponseTraitTest.php

@@ -116,14 +116,10 @@ protected function makeController(string $routePath = '', array $userHeaders = [
         return new class ($this->request, $this->response, $this->formatter) {
             use ResponseTrait;
 
-            protected $request;
-            protected $response;
             protected $formatter;
 
-            public function __construct($request, $response, $formatter)
+            public function __construct(protected $request, protected $response, $formatter)
             {
-                $this->request   = $request;
-                $this->response  = $response;
                 $this->formatter = $formatter;
             }
 
@@ -177,15 +173,11 @@ public function testNoFormatterWithStringAsHtmlTrue(): void
         $controller = new class ($this->request, $this->response, $this->formatter) {
             use ResponseTrait;
 
-            protected $request;
-            protected $response;
             protected $formatter;
             protected bool $stringAsHtml = true;
 
-            public function __construct($request, $response, $formatter)
+            public function __construct(protected $request, protected $response, $formatter)
             {
-                $this->request   = $request;
-                $this->response  = $response;
                 $this->formatter = $formatter;
             }
         };
@@ -299,15 +291,11 @@ public function testRespondSetsCorrectBodyAndStatusWithStringAsHtmlTrue(): void
         $controller = new class ($this->request, $this->response, $this->formatter) {
             use ResponseTrait;
 
-            protected $request;
-            protected $response;
             protected $formatter;
             protected bool $stringAsHtml = true;
 
-            public function __construct($request, $response, $formatter)
+            public function __construct(protected $request, protected $response, $formatter)
             {
-                $this->request   = $request;
-                $this->response  = $response;
                 $this->formatter = $formatter;
             }
         };
@@ -639,14 +627,8 @@ public function testFormatByRequestNegotiateIfFormatIsNotJsonOrXML(): void
         $controller = new class ($request, $response) {
             use ResponseTrait;
 
-            protected $request;
-            protected $response;
-
-            public function __construct($request, $response)
+            public function __construct(protected $request, protected $response)
             {
-                $this->request  = $request;
-                $this->response = $response;
-
                 $this->format = 'txt';
             }
         };