refactor: fix non-booleans in if conditions

Author: paulbalandan

system/View/Parser.php

@@ -115,9 +115,10 @@ public function render(string $view, ?array $options = null, ?bool $saveData = n
         $view    = ($fileExt === '') ? $view . '.php' : $view; // allow Views as .html, .tpl, etc (from CI3)
 
         $cacheName = $options['cache_name'] ?? str_replace('.php', '', $view);
+        $output    = cache($cacheName);
 
         // Was it cached?
-        if (isset($options['cache']) && ($output = cache($cacheName))) {
+        if (isset($options['cache']) && is_string($output) && $output !== '') {
             $this->logPerformance($start, microtime(true), $view);
 
             return $output;

system/View/View.php

@@ -186,7 +186,9 @@ public function render(string $view, ?array $options = null, ?bool $saveData = n
 
             $this->renderVars['cacheName'] = $cacheName;
 
-            if ($output = cache($this->renderVars['cacheName'])) {
+            $output = cache($this->renderVars['cacheName']);
+
+            if (is_string($output) && $output !== '') {
                 $this->logPerformance(
                     $this->renderVars['start'],
                     microtime(true),

utils/phpstan-baseline/booleanAnd.rightNotBoolean.neon

@@ -1,16 +1,14 @@
-# total 3271 errors
+# total 3269 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
-    - booleanAnd.rightNotBoolean.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.getReassignArray.neon
     - codeigniter.modelArgumentType.neon
     - codeigniter.superglobalAccess.neon
     - codeigniter.superglobalAccessAssign.neon
     - deadCode.unreachable.neon
     - empty.notAllowed.neon
-    - if.condNotBoolean.neon
     - method.alreadyNarrowedType.neon
     - method.childParameterType.neon
     - method.childReturnType.neon