refactor: more applied suggest recommendation

Author: ddevsr

app/Config/CURLRequest.php

@@ -8,10 +8,10 @@ class CURLRequest extends BaseConfig
 {
     /**
      * --------------------------------------------------------------------------
-     * CURLRequest Share Connection
+     * CURLRequest Share Connection Options
      * --------------------------------------------------------------------------
      *
-     * Whether share connection between requests.
+     * Share connection options between requests.
      *
      * @var list<int>
      *

system/HTTP/CURLRequest.php

@@ -103,7 +103,7 @@ class CURLRequest extends OutgoingRequest
     private readonly bool $shareOptions;
 
     /**
-     * Whether share connection between requests.
+     * The share connection instance.
      */
     protected ?CurlShareHandle $shareConnection = null;
 

tests/system/HTTP/CURLRequestShareOptionsTest.php

@@ -28,16 +28,16 @@
 #[Group('Others')]
 final class CURLRequestShareOptionsTest extends CURLRequestTest
 {
-    protected function getRequest(array $options = [], bool $emptyShareConnection = false): MockCURLRequest
+    protected function getRequest(array $options = [], ?array $shareConnectionOptions = null): MockCURLRequest
     {
         $uri = isset($options['baseURI']) ? new URI($options['baseURI']) : new URI();
         $app = new App();
 
         $config               = new ConfigCURLRequest();
         $config->shareOptions = true;
 
-        if ($emptyShareConnection) {
-            $config->shareConnectionOptions = [];
+        if ($shareConnectionOptions !== null) {
+            $config->shareConnectionOptions = $shareConnectionOptions;
         }
 
         Factories::injectMock('config', 'CURLRequest', $config);

tests/system/HTTP/CURLRequestTest.php

@@ -21,6 +21,7 @@
 use Config\App;
 use Config\CURLRequest as ConfigCURLRequest;
 use CURLFile;
+use CurlShareHandle;
 use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
@@ -45,17 +46,18 @@ protected function setUp(): void
 
     /**
      * @param array<string, mixed> $options
+     * @param array<int, int>|null $shareConnectionOptions
      */
-    protected function getRequest(array $options = [], bool $emptyShareConnection = false): MockCURLRequest
+    protected function getRequest(array $options = [], ?array $shareConnectionOptions = null): MockCURLRequest
     {
         $uri = isset($options['baseURI']) ? new URI($options['baseURI']) : new URI();
         $app = new App();
 
         $config               = new ConfigCURLRequest();
         $config->shareOptions = false;
 
-        if ($emptyShareConnection) {
-            $config->shareConnectionOptions = [];
+        if ($shareConnectionOptions !== null) {
+            $config->shareConnectionOptions = $shareConnectionOptions;
         }
 
         Factories::injectMock('config', 'CURLRequest', $config);
@@ -1247,18 +1249,35 @@ public function testShareConnectionDefault(): void
         $options = $this->request->curl_options;
 
         $this->assertArrayHasKey(CURLOPT_SHARE, $options);
+        $this->assertInstanceOf(CurlShareHandle::class, $options[CURLOPT_SHARE]);
     }
 
     public function testShareConnectionEmpty(): void
     {
-        $request = $this->getRequest(emptyShareConnection: true);
+        $request = $this->getRequest(shareConnectionOptions: []);
         $request->request('GET', 'http://example.com');
 
         $options = $request->curl_options;
 
         $this->assertArrayNotHasKey(CURLOPT_SHARE, $options);
     }
 
+    public function testShareConnectionDuplicate(): void
+    {
+        $request = $this->getRequest(shareConnectionOptions: [
+            CURL_LOCK_DATA_CONNECT,
+            CURL_LOCK_DATA_DNS,
+            CURL_LOCK_DATA_CONNECT,
+            CURL_LOCK_DATA_DNS,
+        ]);
+        $request->request('GET', 'http://example.com');
+
+        $options = $request->curl_options;
+
+        $this->assertArrayHasKey(CURLOPT_SHARE, $options);
+        $this->assertInstanceOf(CurlShareHandle::class, $options[CURLOPT_SHARE]);
+    }
+
     /**
      * @return iterable<string, array{input: int|string|null, expectedHasKey: bool, expectedValue?: int}>
      *

user_guide_src/source/libraries/curlrequest/039.php

@@ -8,10 +8,10 @@ class CURLRequest extends BaseConfig
 {
     /**
      * --------------------------------------------------------------------------
-     * CURLRequest Share Connection
+     * CURLRequest Share Connection Options
      * --------------------------------------------------------------------------
      *
-     * Whether share connection between requests.
+     * Share connection options between requests.
      *
      * @var list<int>
      *

user_guide_src/source/libraries/curlrequest/040.php

@@ -8,10 +8,10 @@ class CURLRequest extends BaseConfig
 {
     /**
      * --------------------------------------------------------------------------
-     * CURLRequest Share Connection
+     * CURLRequest Share Connection Options
      * --------------------------------------------------------------------------
      *
-     * Whether share connection between requests.
+     * Share connection options between requests.
      *
      * @var list<int>
      *