fix: more coverage

Author: ddevsr

system/HTTP/CURLRequest.php

@@ -617,8 +617,8 @@ protected function setCURLOptions(array $curlOptions = [], array $config = [])
         }
 
         // DNS Cache Timeout
-        if (isset($config['dns_cache_timeout']) && is_numeric($config['dns_cache_timeout']) && $config['dns_cache_timeout'] > 0) {
-            $curlOptions[CURLOPT_DNS_CACHE_TIMEOUT] = $config['dns_cache_timeout'];
+        if (isset($config['dns_cache_timeout']) && is_numeric($config['dns_cache_timeout']) && $config['dns_cache_timeout'] >= -1) {
+            $curlOptions[CURLOPT_DNS_CACHE_TIMEOUT] = (int) $config['dns_cache_timeout'];
         }
 
         // Timeout

tests/system/HTTP/CURLRequestTest.php

@@ -1215,6 +1215,8 @@ public function testForceResolveIPUnknown(): void
 
     /**
      * @return array<string, array<string, bool|int|string>>
+     *
+     * @see https://linux.die.net/man/3/curl_easy_setopt
      */
     public static function provideDNSCacheTimeout(): iterable
     {
@@ -1227,7 +1229,17 @@ public static function provideDNSCacheTimeout(): iterable
             'valid timeout (numeric string)' => [
                 'input'          => '180',
                 'expectedHasKey' => true,
-                'expectedValue'  => '180',
+                'expectedValue'  => 180,
+            ],
+            'valid timeout (zero / disabled)' => [
+                'input'          => 0,
+                'expectedHasKey' => true,
+                'expectedValue'  => 0,
+            ],
+            'valid timeout (forever)' => [
+                'input'          => -1,
+                'expectedHasKey' => true,
+                'expectedValue'  => -1,
             ],
             'invalid timeout (null)' => [
                 'input'          => null,
@@ -1237,11 +1249,7 @@ public static function provideDNSCacheTimeout(): iterable
                 'input'          => 'is_wrong',
                 'expectedHasKey' => false,
             ],
-            'invalid timeout (zero)' => [
-                'input'          => 0,
-                'expectedHasKey' => false,
-            ],
-            'invalid timeout (negative number)' => [
+            'invalid timeout (negative number / below -1)' => [
                 'input'          => -2,
                 'expectedHasKey' => false,
             ],