refactor: Fix phpstan expr.resultUnused (#9385)

neznaika0 · web-flow · commit 3eb8a095144a · 2025-01-09T00:04:11.000+08:00
diff --git a/tests/system/Cookie/CookieTest.php b/tests/system/Cookie/CookieTest.php
@@ -303,7 +303,7 @@ public function testArrayAccessOfCookie(): void
         $this->assertSame($cookie['path'], $cookie->getPath());
 
         $this->expectException('InvalidArgumentException');
-        $cookie['expiry'];
+        $cookie['expiry']; // @phpstan-ignore expr.resultUnused
     }
 
     public function testCannotSetPropertyViaArrayAccess(): void
diff --git a/tests/system/Entity/EntityTest.php b/tests/system/Entity/EntityTest.php
@@ -479,7 +479,7 @@ public function testCastTimestampException(): void
         $entity        = $this->getCastEntity();
         $entity->ninth = 'some string';
 
-        $entity->ninth;
+        $entity->ninth; // @phpstan-ignore expr.resultUnused
     }
 
     public function testCastArray(): void
diff --git a/utils/phpstan-baseline/expr.resultUnused.neon b/utils/phpstan-baseline/expr.resultUnused.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -14,7 +14,6 @@ includes:
     - deadCode.unreachable.neon
     - empty.notAllowed.neon
     - empty.property.neon
-    - expr.resultUnused.neon
     - function.alreadyNarrowedType.neon
     - generator.valueType.neon
     - isset.offset.neon

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ public function testArrayAccessOfCookie(): void`
`303`	`303`	`$this->assertSame($cookie['path'], $cookie->getPath());`
`304`	`304`
`305`	`305`	`$this->expectException('InvalidArgumentException');`
`306`		`- $cookie['expiry'];`
	`306`	`+ $cookie['expiry']; // @phpstan-ignore expr.resultUnused`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`public function testCannotSetPropertyViaArrayAccess(): void`
Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ public function testCastTimestampException(): void`
`479`	`479`	`$entity = $this->getCastEntity();`
`480`	`480`	`$entity->ninth = 'some string';`
`481`	`481`
`482`		`- $entity->ninth;`
	`482`	`+ $entity->ninth; // @phpstan-ignore expr.resultUnused`
`483`	`483`	`}`
`484`	`484`
`485`	`485`	`public function testCastArray(): void`