fix: Apply suggestions

Author: neznaika0

system/Honeypot/Exceptions/HoneypotException.php

@@ -37,16 +37,6 @@ public static function forNoNameField()
         return new static(lang('Honeypot.noNameField'));
     }
 
-    /**
-     * Thrown when the hidden value of config is false.
-     *
-     * @return static
-     */
-    public static function forNoHiddenValue()
-    {
-        return new static(lang('Honeypot.noHiddenValue'));
-    }
-
     /**
      * Thrown when there are no data in the request of honeypot field.
      *

system/I18n/Exceptions/I18nException.php

@@ -72,7 +72,7 @@ public static function forInvalidOverDay(string $lastDay, string $day)
      */
     public static function forInvalidHour(string $hour)
     {
-        return new static(lang('Time.invalidHour', [$hour]));
+        return new static(lang('Time.invalidHours', [$hour]));
     }
 
     /**

system/Language/en/Honeypot.php

@@ -15,6 +15,5 @@
 return [
     'noTemplate'      => 'The HTML template for the Honeypot is not configured.',
     'noNameField'     => 'The name of the Honeypot field has not been set.',
-    'noHiddenValue'   => 'The Honeypot should be invisible to humans.',
     'theClientIsABot' => 'The Honeypot client may be a bot.',
 ];

system/Language/en/Router.php

@@ -13,7 +13,7 @@
 
 // Router language settings
 return [
-    'invalidParameterType'     => 'A parameter does not match the expected type.',
+    'invalidParameter'         => 'A parameter does not match the expected type.',
     'missingDefaultRoute'      => 'Unable to determine what should be displayed. A default route has not been specified in the routing file.',
     'invalidDynamicController' => 'A dynamic controller is not allowed for security reasons. Route handler: "{0}"',
     'invalidControllerName'    => 'The namespace delimiter is a backslash (\\), not a slash (/). Route handler: "{0}"',

system/Language/en/Security.php

@@ -17,6 +17,5 @@
     'insecureCookie'   => 'Attempted to send a secure cookie over a non-secure connection.',
 
     // @deprecated
-    'invalidSameSite'        => 'The SameSite value must be None, Lax, Strict, or a blank string. Given: "{0}"',
-    'invalidSameSiteSetting' => 'The SameSite setting must be None, Lax, Strict, or a blank string. Given: {0}',
+    'invalidSameSite' => 'The SameSite value must be None, Lax, Strict, or a blank string. Given: "{0}"',
 ];

system/Language/en/Time.php

@@ -32,5 +32,4 @@
     'yesterday'      => 'Yesterday',
     'tomorrow'       => 'Tomorrow',
     'now'            => 'Just now',
-    'invalidHour'    => 'The supplied hour "{0}" is outside the range of allowed hours (1-24).',
 ];

system/Router/Exceptions/RouterException.php

@@ -28,7 +28,7 @@ class RouterException extends FrameworkException implements ExceptionInterface
      */
     public static function forInvalidParameterType()
     {
-        return new static(lang('Router.invalidParameterType'));
+        return new static(lang('Router.invalidParameter'));
     }
 
     /**

user_guide_src/source/changelogs/v4.6.4.rst

@@ -18,17 +18,19 @@ BREAKING
 Message Changes
 ***************
 
-- Added ``Honeypot.noTemplate``, ``Honeypot.noNameField``, ``Honeypot.noHiddenValue``, ``Honeypot.theClientIsABot``.
-- Added ``Time.invalidHour``.
-- Changed ``Router.invalidParameter`` to ``Router.invalidParameterType``.
-- Added deprecated ``Security.invalidSameSiteSetting``.
+- Added ``Honeypot.noTemplate``, ``Honeypot.noNameField``, ``Honeypot.theClientIsABot``.
 
 *******
 Changes
 *******
 
 - **Config:** Added the ``synchronous`` key for ``Config\Database::$tests``. For SQLite3 driver only.
 
+Exceptions
+==========
+
+- The unused ``CodeIgniter\Honeypot\Exceptions\HoneypotException::forNoHiddenValue()`` method has been removed.
+
 ************
 Deprecations
 ************