refactor: more !== 1 compare on preg_match()

Author: samsonasik

system/Email/Email.php

@@ -495,7 +495,7 @@ public function setFrom($from, $name = '', $returnPath = null)
 
         if ($name !== '') {
             // only use Q encoding if there are characters that would require it
-            if (in_array(preg_match('/[\200-\377]/', $name), [0, false], true)) {
+            if (preg_match('/[\200-\377]/', $name) !== 1) {
                 $name = '"' . addcslashes($name, "\0..\37\177'\"\\") . '"';
             } else {
                 $name = $this->prepQEncoding($name);
@@ -532,7 +532,7 @@ public function setReplyTo($replyto, $name = '')
             $this->tmpArchive['replyName'] = $name;
 
             // only use Q encoding if there are characters that would require it
-            if (in_array(preg_match('/[\200-\377]/', $name), [0, false], true)) {
+            if (preg_match('/[\200-\377]/', $name) !== 1) {
                 $name = '"' . addcslashes($name, "\0..\37\177'\"\\") . '"';
             } else {
                 $name = $this->prepQEncoding($name);

system/Helpers/html_helper.php

@@ -112,7 +112,7 @@ function img($src = '', bool $indexPage = false, $attributes = ''): string
         $img = '<img';
 
         // Check for a relative URI
-        if (in_array(preg_match('#^([a-z]+:)?//#i', $src['src']), [0, false], true) && ! str_starts_with($src['src'], 'data:')) {
+        if (preg_match('#^([a-z]+:)?//#i', $src['src']) !== 1 && ! str_starts_with($src['src'], 'data:')) {
             if ($indexPage) {
                 $img .= ' src="' . site_url($src['src']) . '"';
             } else {
@@ -206,7 +206,7 @@ function script_tag($src = '', bool $indexPage = false): string
         }
 
         foreach ($src as $k => $v) {
-            if ($k === 'src' && in_array(preg_match('#^([a-z]+:)?//#i', $v), [0, false], true)) {
+            if ($k === 'src' && preg_match('#^([a-z]+:)?//#i', $v) !== 1) {
                 if ($indexPage) {
                     $script .= 'src="' . site_url($v) . '" ';
                 } else {
@@ -252,7 +252,7 @@ function link_tag(
             $href      = $href['href'] ?? '';
         }
 
-        if (in_array(preg_match('#^([a-z]+:)?//#i', $href), [0, false], true)) {
+        if (preg_match('#^([a-z]+:)?//#i', $href) !== 1) {
             $attributes['href'] = $indexPage ? site_url($href) : slash_item('baseURL') . $href;
         } else {
             $attributes['href'] = $href;

system/Router/RouteCollection.php

@@ -1391,7 +1391,7 @@ protected function buildReverseRoute(string $from, array $params): string
             // or maybe $placeholder is not a placeholder, but a regex.
             $pattern = $this->placeholders[$placeholderName] ?? $placeholder;
 
-            if (in_array(preg_match('#^' . $pattern . '$#u', (string) $params[$index]), [0, false], true)) {
+            if (preg_match('#^' . $pattern . '$#u', (string) $params[$index]) !== 1) {
                 throw RouterException::forInvalidParameterType();
             }
 

system/Session/Handlers/FileHandler.php

@@ -290,7 +290,7 @@ public function gc($max_lifetime)
 
         while (($file = readdir($directory)) !== false) {
             // If the filename doesn't match this pattern, it's either not a session file or is not ours
-            if (in_array(preg_match($pattern, $file), [0, false], true)
+            if (preg_match($pattern, $file) !== 1
                 || ! is_file($this->savePath . DIRECTORY_SEPARATOR . $file)
                 || ($mtime = filemtime($this->savePath . DIRECTORY_SEPARATOR . $file)) === false
                 || $mtime > $ts

system/Session/Session.php

@@ -234,7 +234,7 @@ public function start()
 
         // Sanitize the cookie, because apparently PHP doesn't do that for userspace handlers
         if (isset($_COOKIE[$this->config->cookieName])
-            && (! is_string($_COOKIE[$this->config->cookieName]) || in_array(preg_match('#\A' . $this->sidRegexp . '\z#', $_COOKIE[$this->config->cookieName]), [0, false], true))
+            && (! is_string($_COOKIE[$this->config->cookieName]) || preg_match('#\A' . $this->sidRegexp . '\z#', $_COOKIE[$this->config->cookieName]) !== 1)
         ) {
             unset($_COOKIE[$this->config->cookieName]);
         }

system/Typography/Typography.php

@@ -171,7 +171,7 @@ public function autoTypography(string $str, bool $reduceLinebreaks = false): str
         }
 
         // No opening block level tag? Add it if needed.
-        if (in_array(preg_match('/^\s*<(?:' . $this->blockElements . ')/i', $str), [0, false], true)) {
+        if (preg_match('/^\s*<(?:' . $this->blockElements . ')/i', $str) !== 1) {
             $str = preg_replace('/^(.*?)<(' . $this->blockElements . ')/i', '<p>$1</p><$2', $str);
         }