run rector & phpstan

Author: ddevsr

phpstan.neon.dist

@@ -2,7 +2,7 @@ includes:
     - utils/phpstan-baseline/loader.neon
 
 parameters:
-    phpVersion: 80100
+    phpVersion: 80200
     tmpDir: build/phpstan
     level: 6
     bootstrapFiles:

system/API/ResponseTrait.php

@@ -26,8 +26,6 @@
  *
  * @property CLIRequest|IncomingRequest $request
  * @property ResponseInterface          $response
- * @property bool                       $stringAsHtml Whether to treat string data as HTML in JSON response.
- *                                                    Setting `true` is only for backward compatibility.
  */
 trait ResponseTrait
 {
@@ -84,6 +82,12 @@ trait ResponseTrait
      */
     protected $formatter;
 
+    /**
+     * Whether to treat string data as HTML in JSON response.
+     * Setting `true` is only for backward compatibility.
+     */
+    protected bool $stringAsHtml = false;
+
     /**
      * Provides a single, simple method to return an API response, formatted
      * to match the requested format, with proper content-type and status code.

system/Cache/FactoriesCache.php

@@ -16,9 +16,9 @@
 use CodeIgniter\Cache\FactoriesCache\FileVarExportHandler;
 use CodeIgniter\Config\Factories;
 
-final class FactoriesCache
+final readonly class FactoriesCache
 {
-    private readonly CacheInterface|FileVarExportHandler $cache;
+    private CacheInterface|FileVarExportHandler $cache;
 
     public function __construct(CacheInterface|FileVarExportHandler|null $cache = null)
     {

system/Commands/Utilities/Routes/AutoRouteCollector.php

@@ -18,12 +18,12 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\AutoRouteCollectorTest
  */
-final class AutoRouteCollector
+final readonly class AutoRouteCollector
 {
     /**
      * @param string $namespace namespace to search
      */
-    public function __construct(private readonly string $namespace, private readonly string $defaultController, private readonly string $defaultMethod)
+    public function __construct(private string $namespace, private string $defaultController, private string $defaultMethod)
     {
     }
 

system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php

@@ -21,7 +21,7 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\AutoRouterImproved\AutoRouteCollectorTest
  */
-final class AutoRouteCollector
+final readonly class AutoRouteCollector
 {
     /**
      * @param string             $namespace            namespace to search
@@ -31,12 +31,12 @@ final class AutoRouteCollector
      * @param string             $prefix               URI prefix for Module Routing
      */
     public function __construct(
-        private readonly string $namespace,
-        private readonly string $defaultController,
-        private readonly string $defaultMethod,
-        private readonly array $httpMethods,
-        private readonly array $protectedControllers,
-        private readonly string $prefix = '',
+        private string $namespace,
+        private string $defaultController,
+        private string $defaultMethod,
+        private array $httpMethods,
+        private array $protectedControllers,
+        private string $prefix = '',
     ) {
     }
 

system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php

@@ -22,18 +22,18 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\AutoRouterImproved\ControllerMethodReaderTest
  */
-final class ControllerMethodReader
+final readonly class ControllerMethodReader
 {
-    private readonly bool $translateURIDashes;
-    private readonly bool $translateUriToCamelCase;
+    private bool $translateURIDashes;
+    private bool $translateUriToCamelCase;
 
     /**
      * @param string       $namespace   the default namespace
      * @param list<string> $httpMethods
      */
     public function __construct(
-        private readonly string $namespace,
-        private readonly array $httpMethods,
+        private string $namespace,
+        private array $httpMethods,
     ) {
         $config                        = config(Routing::class);
         $this->translateURIDashes      = $config->translateURIDashes;

system/Commands/Utilities/Routes/ControllerFinder.php

@@ -20,15 +20,15 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\ControllerFinderTest
  */
-final class ControllerFinder
+final readonly class ControllerFinder
 {
-    private readonly FileLocatorInterface $locator;
+    private FileLocatorInterface $locator;
 
     /**
      * @param string $namespace namespace to search
      */
     public function __construct(
-        private readonly string $namespace,
+        private string $namespace,
     ) {
         $this->locator = service('locator');
     }

system/Commands/Utilities/Routes/ControllerMethodReader.php

@@ -21,12 +21,12 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\ControllerMethodReaderTest
  */
-final class ControllerMethodReader
+final readonly class ControllerMethodReader
 {
     /**
      * @param string $namespace the default namespace
      */
-    public function __construct(private readonly string $namespace)
+    public function __construct(private string $namespace)
     {
     }
 

system/Commands/Utilities/Routes/FilterCollector.php

@@ -24,15 +24,15 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\FilterCollectorTest
  */
-final class FilterCollector
+final readonly class FilterCollector
 {
     public function __construct(
         /**
          * Whether to reset Defined Routes.
          *
          * If set to true, route filters are not found.
          */
-        private readonly bool $resetRoutes = false,
+        private bool $resetRoutes = false,
     ) {
     }
 

system/Commands/Utilities/Routes/FilterFinder.php

@@ -25,10 +25,10 @@
  *
  * @see \CodeIgniter\Commands\Utilities\Routes\FilterFinderTest
  */
-final class FilterFinder
+final readonly class FilterFinder
 {
-    private readonly Router $router;
-    private readonly Filters $filters;
+    private Router $router;
+    private Filters $filters;
 
     public function __construct(?Router $router = null, ?Filters $filters = null)
     {