Fix per review

Author: paulbalandan

system/Debug/Toolbar/Collectors/Logs.php

@@ -92,6 +92,10 @@ protected function collectLogs()
             return $this->data;
         }
 
-        return $this->data = service('logger', true)->logCache;
+        $cache = service('logger')->logCache;
+
+        $this->data = $cache ?? [];
+
+        return $this->data;
     }
 }

system/Log/Handlers/FileHandler.php

@@ -28,21 +28,21 @@ class FileHandler extends BaseHandler
      *
      * @var string
      */
-    protected $path = WRITEPATH . 'logs/';
+    protected $path;
 
     /**
      * Extension to use for log files
      *
      * @var string
      */
-    protected $fileExtension = 'log';
+    protected $fileExtension;
 
     /**
      * Permissions for new log files
      *
      * @var int
      */
-    protected $filePermissions = 0644;
+    protected $filePermissions;
 
     /**
      * @param array{handles?: list<string>, path?: string, fileExtension?: string, filePermissions?: int} $config
@@ -51,18 +51,14 @@ public function __construct(array $config = [])
     {
         parent::__construct($config);
 
-        $config = [
-            ...['path' => WRITEPATH . 'logs/', 'fileExtension' => 'log', 'filePermissions' => 0644],
-            ...$config,
-        ];
+        $defaults = ['path' => WRITEPATH . 'logs/', 'fileExtension' => 'log', 'filePermissions' => 0644];
+        $config   = [...$defaults, ...$config];
 
-        if ($config['path'] !== '') {
-            $this->path = $config['path'];
-        }
+        $this->path = $config['path'] === '' ? $defaults['path'] : $config['path'];
 
-        if ($config['fileExtension'] !== '') {
-            $this->fileExtension = ltrim($config['fileExtension'], '.');
-        }
+        $this->fileExtension = $config['fileExtension'] === ''
+            ? $defaults['fileExtension']
+            : ltrim($config['fileExtension'], '.');
 
         $this->filePermissions = $config['filePermissions'];
     }

system/Log/Logger.php

@@ -123,7 +123,7 @@ class Logger implements LoggerInterface
      */
     public function __construct($config, bool $debug = CI_DEBUG)
     {
-        $loggableLevels = is_array($config->threshold) ? $config->threshold : range(1, $config->threshold);
+        $loggableLevels = is_array($config->threshold) ? $config->threshold : range(1, (int) $config->threshold);
 
         // Now convert loggable levels to strings.
         // We only use numbers to make the threshold setting convenient for users.
@@ -142,7 +142,7 @@ public function __construct($config, bool $debug = CI_DEBUG)
             $this->dateFormat = $config->dateFormat;
         }
 
-        if ((array) $config->handlers === []) {
+        if ($config->handlers === []) {
             throw LogException::forNoHandlers('LoggerConfig');
         }