refactor: fix notIdentical.alwaysTrue error

paulbalandan · paulbalandan · commit 595ec188765f · 2025-05-25T21:46:42.000+08:00
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -1093,9 +1093,7 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc
                 $row = $this->doProtectFields($row);
 
                 // Restore updateIndex value in case it was wiped out
-                if ($updateIndex !== null) {
-                    $row[$index] = $updateIndex;
-                }
+                $row[$index] = $updateIndex;
 
                 $row = $this->setUpdatedField($row, $this->setDate());
             }
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,4 +1,4 @@
-# total 3271 errors
+# total 3270 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
@@ -19,7 +19,6 @@ includes:
     - missingType.iterableValue.neon
     - missingType.parameter.neon
     - missingType.property.neon
-    - notIdentical.alwaysTrue.neon
     - nullCoalesce.property.neon
     - offsetAccess.notFound.neon
     - property.defaultValue.neon
diff --git a/utils/phpstan-baseline/notIdentical.alwaysTrue.neon b/utils/phpstan-baseline/notIdentical.alwaysTrue.neon

Original file line number	Diff line number	Diff line change
`@@ -1093,9 +1093,7 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc`
`1093`	`1093`	`$row = $this->doProtectFields($row);`
`1094`	`1094`
`1095`	`1095`	`// Restore updateIndex value in case it was wiped out`
`1096`		`- if ($updateIndex !== null) {`
`1097`		`- $row[$index] = $updateIndex;`
`1098`		`- }`
	`1096`	`+ $row[$index] = $updateIndex;`
`1099`	`1097`
`1100`	`1098`	`$row = $this->setUpdatedField($row, $this->setDate());`
`1101`	`1099`	`}`