tests: added option when set to not numeric

Author: ddevsr

system/HTTP/CURLRequest.php

@@ -617,7 +617,7 @@ protected function setCURLOptions(array $curlOptions = [], array $config = [])
         }
 
         // DNS Cache Timeout
-        if (! empty($config['dns_cache_timeout'])) {
+        if (! empty($config['dns_cache_timeout']) && is_numeric($config['dns_cache_timeout'])) {
             $curlOptions[CURLOPT_DNS_CACHE_TIMEOUT] = (int) $config['dns_cache_timeout'];
         }
 

tests/system/HTTP/CURLRequestTest.php

@@ -1236,6 +1236,18 @@ public function testDNSCacheTimeoutSetOption(): void
         $this->assertSame($timeout, $options[CURLOPT_DNS_CACHE_TIMEOUT]);
     }
 
+    public function testDNSCacheTimeoutWrongSetOption(): void
+    {
+        $timeout = 'is_wrong';
+        $this->request->request('POST', '/post', [
+            'dns_cache_timeout' => $timeout,
+        ]);
+
+        $options = $this->request->curl_options;
+
+        $this->assertArrayNotHasKey(CURLOPT_DNS_CACHE_TIMEOUT, $options);
+    }
+
     public function testCookieOption(): void
     {
         $holder = SUPPORTPATH . 'HTTP/Files/CookiesHolder.txt';