refactor: clean condition check

Author: samsonasik

system/Config/DotEnv.php

@@ -94,7 +94,7 @@ public function parse(): ?array
      */
     protected function setVariable(string $name, string $value = '')
     {
-        if (in_array(getenv($name, true), ['', '0'], true) || getenv($name, true) === [] || getenv($name, true) === false) {
+        if (in_array(getenv($name, true), ['', '0', [], false], true)) {
             putenv("{$name}={$value}");
         }
 

system/Database/Database.php

@@ -96,7 +96,7 @@ protected function parseDSN(array $params): array
     {
         $dsn = parse_url($params['DSN']);
 
-        if ($dsn === 0 || ($dsn === '' || $dsn === '0') || $dsn === [] || $dsn === false || $dsn === null) {
+        if ($dsn === 0 || $dsn === '' || $dsn === '0' || $dsn === [] || $dsn === false || $dsn === null) {
             throw new InvalidArgumentException('Your DSN connection string is invalid.');
         }
 

system/Database/MigrationRunner.php

@@ -725,7 +725,7 @@ public function getBatchStart(int $batch): string
             ->get()
             ->getResultObject();
 
-        return count($migration) !== 0 ? $migration[0]->version : '0';
+        return count($migration) > 0 ? $migration[0]->version : '0';
     }
 
     /**

system/Images/Image.php

@@ -102,8 +102,9 @@ public function copy(string $targetPath, ?string $targetName = null, int $perms
     public function getProperties(bool $return = false)
     {
         $path = $this->getPathname();
+        $vals = getimagesize($path);
 
-        if ($vals = getimagesize($path) === [] || $vals = getimagesize($path) === false) {
+        if ($vals === [] || $vals === false) {
             throw ImageException::forFileNotSupported();
         }