Skip to content

Commit 88862ad

Browse files
samsonasikpaulbalandan
authored andcommitted
refactor: returns null on DebugToolbar and HoneyPot
1 parent e8178eb commit 88862ad

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

system/Filters/DebugToolbar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ public function after(RequestInterface $request, ResponseInterface $response, $a
4343
{
4444
service('toolbar')->prepare($request, $response);
4545

46-
return $response;
46+
return null;
4747
}
4848
}

system/Filters/Honeypot.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ public function after(RequestInterface $request, ResponseInterface $response, $a
5555
{
5656
service('honeypot')->attachHoneypot($response);
5757

58-
return $response;
58+
return null;
5959
}
6060
}

utils/phpstan-baseline/missingType.iterableValue.neon

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# total 1673 errors
1+
# total 1672 errors
22

33
parameters:
44
ignoreErrors:
@@ -4707,11 +4707,6 @@ parameters:
47074707
count: 1
47084708
path: ../../system/Language/Language.php
47094709

4710-
-
4711-
message: '#^Method CodeIgniter\\Language\\Language\:\:load\(\) return type has no value type specified in iterable type array\.$#'
4712-
count: 1
4713-
path: ../../system/Language/Language.php
4714-
47154710
-
47164711
message: '#^Method CodeIgniter\\Language\\Language\:\:parseLine\(\) return type has no value type specified in iterable type array\.$#'
47174712
count: 1

utils/phpstan-baseline/return.missing.neon

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
# total 2 errors
1+
# total 1 error
22

33
parameters:
44
ignoreErrors:
5-
-
6-
message: '#^Method CodeIgniter\\Images\\Handlers\\BaseHandler\:\:__call\(\) should return mixed but return statement is missing\.$#'
7-
count: 1
8-
path: ../../system/Images/Handlers/BaseHandler.php
9-
105
-
116
message: '#^Method CodeIgniter\\Test\\Mock\\MockResult\:\:fetchAssoc\(\) should return mixed but return statement is missing\.$#'
127
count: 1

0 commit comments

Comments
 (0)