fix phpstan

Author: michalsn

tests/system/CodeIgniterTest.php

@@ -96,7 +96,7 @@ public function testRunEmptyDefaultRouteReturnResponse(): void
         $_SERVER['argc'] = 1;
 
         $response = $this->codeigniter->run(null, true);
-        $this->assertInstanceof(ResponseInterface::class, $response);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
 
         $this->assertStringContainsString('Welcome to CodeIgniter', $response->getBody());
     }
@@ -161,7 +161,7 @@ public function testRun404OverrideControllerReturnsResponse(): void
         Services::injectMock('router', $router);
 
         $response = $this->codeigniter->run($routes, true);
-        $this->assertInstanceof(ResponseInterface::class, $response);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
 
         $this->assertStringContainsString('Oops', $response->getBody());
         $this->assertSame(567, $response->getStatusCode());
@@ -180,7 +180,7 @@ public function testRun404OverrideReturnResponse(): void
         Services::injectMock('router', $router);
 
         $response = $this->codeigniter->run($routes, true);
-        $this->assertInstanceof(ResponseInterface::class, $response);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
 
         $this->assertStringContainsString('Oops', $response->getBody());
     }
@@ -471,7 +471,7 @@ public function testRunForceSecure(): void
         $this->assertNull($response->header('Location'));
 
         $response = $codeigniter->run(null, true);
-        $this->assertInstanceof(ResponseInterface::class, $response);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
 
         $this->assertSame('https://example.com/index.php/', $response->header('Location')->getValue());
     }

tests/system/Database/Live/OCI8/LastInsertIDTest.php

@@ -84,7 +84,7 @@ public function testGetInsertIDWithPreparedQuery(): void
 
             return (new Query($db))->setQuery($sql);
         });
-        $this->assertInstanceof(BasePreparedQuery::class, $query);
+        $this->assertInstanceOf(BasePreparedQuery::class, $query);
 
         $query->execute('foo', 'bar');
         $actual = $this->db->insertID();

tests/system/HTTP/Files/FileCollectionTest.php

@@ -359,7 +359,7 @@ public function testErrorString(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame($expected, $file->getErrorString());
     }
@@ -380,7 +380,7 @@ public function testErrorStringWithUnknownError(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame($expected, $file->getErrorString());
     }
@@ -400,7 +400,7 @@ public function testErrorStringWithNoError(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame($expected, $file->getErrorString());
     }
@@ -419,7 +419,7 @@ public function testError(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame(UPLOAD_ERR_INI_SIZE, $file->getError());
     }
@@ -437,7 +437,7 @@ public function testErrorWithUnknownError(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame(0, $file->getError());
     }
@@ -456,7 +456,7 @@ public function testErrorWithNoError(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame(UPLOAD_ERR_OK, $file->getError());
     }
@@ -475,7 +475,7 @@ public function testClientPathReturnsValidFullPath(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertSame('someDir/someFile.txt', $file->getClientPath());
     }
@@ -493,7 +493,7 @@ public function testClientPathReturnsNullWhenFullPathIsNull(): void
 
         $collection = new FileCollection();
         $file       = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
 
         $this->assertNull($file->getClientPath());
     }

tests/system/HTTP/Files/FileMovingTest.php

@@ -264,7 +264,7 @@ public function testInvalidFile(): void
         $this->expectException(HTTPException::class);
 
         $file = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
         $file->move($destination, $file->getName(), false);
     }
 
@@ -291,7 +291,7 @@ public function testFailedMoveBecauseOfWarning(): void
         $this->expectException(HTTPException::class);
 
         $file = $collection->getFile('userfile');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
         $file->move($destination, $file->getName(), false);
     }
 
@@ -323,7 +323,7 @@ public function testFailedMoveBecauseOfFalseReturned(): void
         $this->expectExceptionMessage('move_uploaded_file() returned false');
 
         $file = $collection->getFile('userfile1');
-        $this->assertInstanceof(UploadedFile::class, $file);
+        $this->assertInstanceOf(UploadedFile::class, $file);
         $file->move($destination, $file->getName(), false);
     }
 }

tests/system/Pager/PagerRendererTest.php

@@ -635,7 +635,7 @@ public function testPageStartEnd(array $details, int $pageStart, int $pageEnd):
     }
 
     /**
-     * @return array<string, array<string, mixed>> $details
+     * @return array<string, list<array<string, int|URI>|int>> $details
      */
     public static function providePageStartEnd(): iterable
     {

tests/system/Test/ControllerTestTraitTest.php

@@ -162,7 +162,7 @@ public function testRequestPassthrough(): void
             ->execute('popper');
 
         $req = $result->request();
-        $this->assertInstanceof(RequestInterface::class, $req);
+        $this->assertInstanceOf(RequestInterface::class, $req);
         $this->assertSame('GET', $req->getMethod());
     }