refactor: fix never empty array on Image

samsonasik · samsonasik · commit 98051214cb8e · 2024-12-27T09:17:16.000+07:00
diff --git a/system/Images/Image.php b/system/Images/Image.php
@@ -104,7 +104,7 @@ public function getProperties(bool $return = false)
         $path = $this->getPathname();
         $vals = getimagesize($path);
 
-        if ($vals === [] || $vals === false) {
+        if ($vals === false) {
             throw ImageException::forFileNotSupported();
         }
 
diff --git a/utils/phpstan-baseline/identical.alwaysFalse.neon b/utils/phpstan-baseline/identical.alwaysFalse.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -28,7 +28,6 @@ includes:
     - generator.returnType.neon
     - generator.valueType.neon
     - greaterOrEqual.invalid.neon
-    - identical.alwaysFalse.neon
     - if.condNotBoolean.neon
     - isset.offset.neon
     - isset.property.neon

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public function getProperties(bool $return = false)`
`104`	`104`	`$path = $this->getPathname();`
`105`	`105`	`$vals = getimagesize($path);`
`106`	`106`
`107`		`- if ($vals === [] \|\| $vals === false) {`
	`107`	`+ if ($vals === false) {`
`108`	`108`	`throw ImageException::forFileNotSupported();`
`109`	`109`	`}`
`110`	`110`