refactor: Fix phpstan codeigniter.frameworkExceptionInstance

neznaika0 · neznaika0 · commit df17203647ef · 2025-01-09T18:39:07.000+03:00
diff --git a/tests/system/Debug/ExceptionsTest.php b/tests/system/Debug/ExceptionsTest.php
@@ -124,7 +124,7 @@ public function testDetermineCodes(): void
         $this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('There.', 404)));
         $this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('This.', 167)));
         $this->assertSame([500, EXIT_CONFIG], $determineCodes(new ConfigException('This.')));
-        $this->assertSame([500, EXIT_CONFIG], $determineCodes(new CastException('This.')));
+        $this->assertSame([500, EXIT_CONFIG], $determineCodes(CastException::forInvalidInterface('This.')));
         $this->assertSame([500, EXIT_DATABASE], $determineCodes(new DatabaseException('This.')));
     }
 
diff --git a/tests/system/DebugTraceableTraitTest.php b/tests/system/DebugTraceableTraitTest.php
@@ -28,6 +28,7 @@ final class DebugTraceableTraitTest extends CIUnitTestCase
 {
     public function testFactoryInstanceReturnsWhereItIsRaised(): void
     {
+        /** @phpstan-ignore codeigniter.frameworkExceptionInstance */
         $e1 = new FrameworkException('Hello.');
         $e2 = FrameworkException::forEnabledZlibOutputCompression();
 
diff --git a/utils/phpstan-baseline/codeigniter.frameworkExceptionInstance.neon b/utils/phpstan-baseline/codeigniter.frameworkExceptionInstance.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -4,7 +4,6 @@ includes:
     - booleanAnd.rightAlwaysTrue.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon
-    - codeigniter.frameworkExceptionInstance.neon
     - codeigniter.getReassignArray.neon
     - codeigniter.modelArgumentInstanceof.neon
     - codeigniter.modelArgumentType.neon

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public function testDetermineCodes(): void`
`124`	`124`	`$this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('There.', 404)));`
`125`	`125`	`$this->assertSame([500, EXIT_ERROR], $determineCodes(new RuntimeException('This.', 167)));`
`126`	`126`	`$this->assertSame([500, EXIT_CONFIG], $determineCodes(new ConfigException('This.')));`
`127`		`- $this->assertSame([500, EXIT_CONFIG], $determineCodes(new CastException('This.')));`
	`127`	`+ $this->assertSame([500, EXIT_CONFIG], $determineCodes(CastException::forInvalidInterface('This.')));`
`128`	`128`	`$this->assertSame([500, EXIT_DATABASE], $determineCodes(new DatabaseException('This.')));`
`129`	`129`	`}`
`130`	`130`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ final class DebugTraceableTraitTest extends CIUnitTestCase`
`28`	`28`	`{`
`29`	`29`	`public function testFactoryInstanceReturnsWhereItIsRaised(): void`
`30`	`30`	`{`
	`31`	`+ /** @phpstan-ignore codeigniter.frameworkExceptionInstance */`
`31`	`32`	`$e1 = new FrameworkException('Hello.');`
`32`	`33`	`$e2 = FrameworkException::forEnabledZlibOutputCompression();`
`33`	`34`