Apply suggestions from code review

Co-authored-by: John Paul E. Balandan, CPA <[email protected]>

Author: michalsn

system/Helpers/text_helper.php

@@ -545,7 +545,7 @@ function reduce_multiples(string $str, string $character = ',', bool $trim = fal
      *
      * Useful for generating passwords or hashes.
      *
-     * @param string $type Type of random string.  basic, alpha, alnum, numeric, nozero, md5, sha1, and crypto
+     * @param string $type Type of random string:  alpha, alnum, numeric, nozero, or crypto
      * @param int    $len  Number of characters
      */
     function random_string(string $type = 'alnum', int $len = 8): string
@@ -587,7 +587,8 @@ function random_string(string $type = 'alnum', int $len = 8): string
         }
 
         throw new InvalidArgumentException(
-            'You must set a valid type to the first parameter when you use `random_string`.',
+            sprintf('Invalid type "%s". Accepted types: alpha, alnum, numeric, nozero, or crypto.'),
+            $type,
         );
     }
 }

tests/system/Helpers/TextHelperTest.php

@@ -151,7 +151,7 @@ public function testRandomStringWithUnsupportedType(): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage(
-            'You must set a valid type to the first parameter when you use `random_string`.',
+           'Invalid type "basic". Accepted types: alpha, alnum, numeric, nozero, or crypto.',
         );
 
         random_string('basic');