build(app): Fixing more analyses errors

Author: lonnieezell

tests/system/CodeIgniterTest.php

@@ -1004,12 +1004,12 @@ public function testRouteAttributeCacheIntegration(): void
 
         // Second request - should return cached version with same timestamp
         $this->resetServices();
-        $_SERVER['argv']           = ['index.php', 'attribute/cached'];
-        $_SERVER['argc']           = 2;
+        $_SERVER['argv'] = ['index.php', 'attribute/cached'];
+        $_SERVER['argc'] = 2;
         Services::superglobals()->setServer('REQUEST_URI', '/attribute/cached');
         Services::superglobals()->setServer('SCRIPT_NAME', '/index.php');
         Services::superglobals()->setServer('REQUEST_METHOD', 'GET');
-        $this->codeigniter         = new MockCodeIgniter(new App());
+        $this->codeigniter = new MockCodeIgniter(new App());
 
         $routes = service('routes');
         $routes->get('attribute/cached', '\Tests\Support\Router\Controllers\AttributeController::cached');

tests/system/Router/Attributes/CacheTest.php

@@ -13,8 +13,8 @@
 
 namespace CodeIgniter\Router\Attributes;
 
-use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\HTTP\IncomingRequest;
+use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\HTTP\SiteURI;
 use CodeIgniter\HTTP\UserAgent;
 use CodeIgniter\Test\CIUnitTestCase;

tests/system/Router/Attributes/FilterTest.php

@@ -13,8 +13,8 @@
 
 namespace CodeIgniter\Router\Attributes;
 
-use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\HTTP\IncomingRequest;
+use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\HTTP\SiteURI;
 use CodeIgniter\HTTP\UserAgent;
 use CodeIgniter\Test\CIUnitTestCase;

tests/system/Router/Attributes/RestrictTest.php

@@ -13,9 +13,9 @@
 
 namespace CodeIgniter\Router\Attributes;
 
-use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\Exceptions\PageNotFoundException;
 use CodeIgniter\HTTP\IncomingRequest;
+use CodeIgniter\HTTP\ResponseInterface;
 use CodeIgniter\HTTP\SiteURI;
 use CodeIgniter\HTTP\UserAgent;
 use CodeIgniter\Test\CIUnitTestCase;

utils/phpstan-baseline/empty.notAllowed.neon

@@ -1,4 +1,4 @@
-# total 231 errors
+# total 230 errors
 
 parameters:
     ignoreErrors:
@@ -287,11 +287,6 @@ parameters:
             count: 4
             path: ../../system/RESTful/BaseResource.php
 
-        -
-            message: '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
-            count: 1
-            path: ../../system/Router/Attributes/Filter.php
-
         -
             message: '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
             count: 6

utils/phpstan-baseline/greaterOrEqual.alwaysTrue.neon

@@ -1,8 +1,4 @@
-# total 1 error
+# total 0 errors
 
 parameters:
-    ignoreErrors:
-        -
-            message: '#^Comparison operation "\>\=" between int\<3, max\> and 3 is always true\.$#'
-            count: 1
-            path: ../../system/Router/Attributes/Restrict.php
+    ignoreErrors: []

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 2817 errors
+# total 2815 errors
 
 includes:
     - argument.type.neon
@@ -10,7 +10,6 @@ includes:
     - codeigniter.superglobalAccessAssign.neon
     - deadCode.unreachable.neon
     - empty.notAllowed.neon
-    - greaterOrEqual.alwaysTrue.neon
     - isset.property.neon
     - method.alreadyNarrowedType.neon
     - method.childParameterType.neon