Bug: Database tests failed

[neznaika0]

PHP Version

8.4

CodeIgniter4 Version

4.6.3

CodeIgniter4 Installation Method

Git

Which operating systems have you tested for this bug?

Linux

Which server did you use?

cli-server (PHP built-in webserver)

Database

11.7.2-MariaDB, SQLite3 3.50.0

What happened?

Run composer test ./tests/system/Database/Live:

There were 93 errors:

1) CodeIgniter\Database\Live\GroupTest::testGroupBy
CodeIgniter\Database\Exceptions\DatabaseException: Unable to prepare statement: no such table: db_migrations

/home/neznaika0/www/codeigniter/development/system/Database/BaseConnection.php:684
/home/neznaika0/www/codeigniter/development/system/Database/BaseBuilder.php:1649
/home/neznaika0/www/codeigniter/development/system/Database/MigrationRunner.php:693
/home/neznaika0/www/codeigniter/development/system/Database/MigrationRunner.php:233
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:147
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:114
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:60
/home/neznaika0/www/codeigniter/development/system/Test/CIUnitTestCase.php:251

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: Unable to prepare statement: no such table: db_migrations

/home/neznaika0/www/codeigniter/development/system/Database/SQLite3/Connection.php:181
/home/neznaika0/www/codeigniter/development/system/Database/BaseConnection.php:729
/home/neznaika0/www/codeigniter/development/system/Database/BaseConnection.php:646
/home/neznaika0/www/codeigniter/development/system/Database/BaseBuilder.php:1649
/home/neznaika0/www/codeigniter/development/system/Database/MigrationRunner.php:693
/home/neznaika0/www/codeigniter/development/system/Database/MigrationRunner.php:233
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:147
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:114
/home/neznaika0/www/codeigniter/development/system/Test/DatabaseTestTrait.php:60
/home/neznaika0/www/codeigniter/development/system/Test/CIUnitTestCase.php:251
...
2) CodeIgniter\Database\Live\GroupTest::testHavingBy
CodeIgniter\Database\Exceptions\DatabaseException: Unable to prepare statement: no such table: db_migrations
...
3) CodeIgniter\Database\Live\GroupTest::testOrHavingBy
CodeIgniter\Database\Exceptions\DatabaseException: Unable to prepare statement: no such table: db_migrations
...

The error trace is the same - the problem is cleaning the database.

The file writable/database.db is created, tests are performed individually. This may be related to :memory: for SQLite?

Steps to Reproduce

Clone development repo and run tests.

Expected Output

The tests must be successful.

Anything else?

My PC:
Linux arch-pc 6.15.8-arch1-2
11.7.2-MariaDB
SQLite3 3.50.0
PHP 8.4.7

[neznaika0]

Found #9471

CodeIgniter4/tests/system/Database/Live/GetVersionTest.php

Line 36 in 249b88a

$this->db->connID = false;

@michalsn can you explain the connection reset?

[michalsn]

@neznaika0 From the context, I assume the intention was to test the getVersion() method when no connection had been established.

[neznaika0]

In this case, the following tests do not recreate the tables that the migrations (runner) create

[michalsn]

You can try to remove the protected $migrate = false; from this test, although I cannot reproduce this.

[neznaika0]

No, it doesn't work. The problem is closing the connection

[michalsn]

Feel free to remove it then.

[neznaika0]

$this->db->connID = false; this line? Send PR and test github-actions?

[michalsn]

Yes, this and everything before it. Tests should be consistent across all handlers.

If someone can confirm that this is indeed an issue, then yes, I will approve these changes.

However, I cannot reproduce the problem locally, and our tests are passing as expected. At this point, it appears to be something specific to your environment.

[paulbalandan]

I can reproduce these errors by either running composer test tests/system/Database/Live or vendor/bin/phpunit tests/system/Database/Live but immediately passes if I precede the call with DB=SQLite3. So calling DB=SQLite3 vendor/bin/phpunit tests/system/Database/Live passes.

[michalsn]

Okay, this seems a bit unpredictable. If someone wants to investigate this, please do. It's strange, as the tests pass fine with GitHub Actions. Anyway, the previously proposed change of simplifying the test is also acceptable to me.

[neznaika0]

@paulbalandan @michalsn #9669 testing slows down a lot.
See https://github.com/paulbalandan/CodeIgniter4/blob/2a0003ded1331d5c09e806e9e39c68832be025d8/tests/_support/Config/Registrar.php#L139

The tests pass, there is a time limit, but it takes ~7 minutes.. My research on speed:

4.6.3
Time: 02:11.160, Memory: 256.50 MB
Tests: 7199, Assertions: 17376, Errors: 93, Failures: 2, Skipped: 39.

4.6.4 (develop)
Timeout composer ...4380 / 7203 ( 60%)

4.6.4 (w\o timeout)
Time: 06:57.313, Memory: 254.50 MB

4.7 (last)
Timeout composer ...4453 / 7263 ( 61%)

[paulbalandan]

I am running on latest develop:

❯ vendor/bin/phpunit --group DatabaseLive
PHPUnit 11.5.36 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.12 with Xdebug 3.4.5
Configuration: /Users/paul/Workspace/CodeIgniter4/phpunit.xml.dist

..S.......................................................................................SSS...S...........S........................ 133 / 795 ( 16%)
...................................................................................SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS....S........... 266 / 795 ( 33%)
.....................................................................................S............................................... 399 / 795 ( 50%)
..................................................................................................................................... 532 / 795 ( 66%)
.....................................................................................................SS.............................. 665 / 795 ( 83%)
.............................SSSSSSSSSSSS.........................................................................................    795 / 795 (100%)

Time: 00:21.933, Memory: 126.50 MB

OK, but some tests were skipped!
Tests: 795, Assertions: 1545, Skipped: 56.

Generating code coverage report in Clover XML format ... done [00:00.252]

Generating code coverage report in HTML format ... done [00:03.810]

I ran it 3 times and time spent was 19 to 26 seconds.