From 4eabe0a1d3970cba4aa226cdc1071581a442771d Mon Sep 17 00:00:00 2001 From: Aselsan Date: Wed, 5 Mar 2025 14:31:45 +0700 Subject: [PATCH 1/3] fix: Inconsistent directives value between default and OPCache groups --- system/Security/CheckPhpIni.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/Security/CheckPhpIni.php b/system/Security/CheckPhpIni.php index e2ff075678cd..9d419d0c1309 100644 --- a/system/Security/CheckPhpIni.php +++ b/system/Security/CheckPhpIni.php @@ -135,7 +135,7 @@ public static function checkIni(?string $argument = null): array 'date.timezone' => ['recommended' => 'UTC'], 'mbstring.language' => ['recommended' => 'neutral'], 'opcache.enable' => ['recommended' => '1'], - 'opcache.enable_cli' => ['recommended' => '1'], + 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using CLI'], 'opcache.jit' => ['recommended' => 'tracing'], 'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], 'zend.assertions' => ['recommended' => '-1'], From c55a047d773d019ac0cb8983e102c1c094279e86 Mon Sep 17 00:00:00 2001 From: Aselsan Date: Wed, 19 Mar 2025 11:07:41 +0700 Subject: [PATCH 2/3] improve remark message --- system/Security/CheckPhpIni.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/Security/CheckPhpIni.php b/system/Security/CheckPhpIni.php index 9d419d0c1309..1fbc88d11fd2 100644 --- a/system/Security/CheckPhpIni.php +++ b/system/Security/CheckPhpIni.php @@ -135,7 +135,7 @@ public static function checkIni(?string $argument = null): array 'date.timezone' => ['recommended' => 'UTC'], 'mbstring.language' => ['recommended' => 'neutral'], 'opcache.enable' => ['recommended' => '1'], - 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using CLI'], + 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using queues or running repetitive CLI tasks'], 'opcache.jit' => ['recommended' => 'tracing'], 'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], 'zend.assertions' => ['recommended' => '-1'], @@ -144,7 +144,7 @@ public static function checkIni(?string $argument = null): array if ($argument === 'opcache') { $items = [ 'opcache.enable' => ['recommended' => '1'], - 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using CLI'], + 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using queues or running repetitive CLI tasks'], 'opcache.jit' => ['recommended' => 'tracing', 'remark' => 'Disable when you used third-party extensions'], 'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], 'opcache.memory_consumption' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], From cc64430aac2eab24ce3e66c171eb4eed0cc98c59 Mon Sep 17 00:00:00 2001 From: Aselsan Date: Wed, 19 Mar 2025 19:36:28 +0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: John Paul E. Balandan, CPA --- system/Security/CheckPhpIni.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/Security/CheckPhpIni.php b/system/Security/CheckPhpIni.php index 1fbc88d11fd2..35431c35af57 100644 --- a/system/Security/CheckPhpIni.php +++ b/system/Security/CheckPhpIni.php @@ -135,7 +135,7 @@ public static function checkIni(?string $argument = null): array 'date.timezone' => ['recommended' => 'UTC'], 'mbstring.language' => ['recommended' => 'neutral'], 'opcache.enable' => ['recommended' => '1'], - 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using queues or running repetitive CLI tasks'], + 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you are using queues or running repetitive CLI tasks'], 'opcache.jit' => ['recommended' => 'tracing'], 'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], 'zend.assertions' => ['recommended' => '-1'], @@ -144,7 +144,7 @@ public static function checkIni(?string $argument = null): array if ($argument === 'opcache') { $items = [ 'opcache.enable' => ['recommended' => '1'], - 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using queues or running repetitive CLI tasks'], + 'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you are using queues or running repetitive CLI tasks'], 'opcache.jit' => ['recommended' => 'tracing', 'remark' => 'Disable when you used third-party extensions'], 'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'], 'opcache.memory_consumption' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'],