move create table to private method

Author: kpeu3u

src/Database/Migrations/2020-12-28-223112_create_auth_tables.php

@@ -16,17 +16,15 @@ class CreateAuthTables extends Migration
     private array $tables;
 
     private array $attributes;
-    private bool $ifNotExists;
 
     public function __construct(?Forge $forge = null)
     {
         parent::__construct($forge);
 
         /** @var Auth $authConfig */
-        $authConfig        = config('Auth');
-        $this->tables      = $authConfig->tables;
-        $this->ifNotExists = false;
-        $this->attributes  = ($this->db->getPlatform() === 'MySQLi') ? ['ENGINE' => 'InnoDB'] : [];
+        $authConfig       = config('Auth');
+        $this->tables     = $authConfig->tables;
+        $this->attributes = ($this->db->getPlatform() === 'MySQLi') ? ['ENGINE' => 'InnoDB'] : [];
     }
 
     public function up(): void
@@ -45,7 +43,7 @@ public function up(): void
         ]);
         $this->forge->addPrimaryKey('id');
         $this->forge->addUniqueKey('username');
-        $this->forge->createTable($this->tables['users'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['users']);
 
         /*
          * Auth Identities Table
@@ -69,7 +67,7 @@ public function up(): void
         $this->forge->addUniqueKey(['type', 'secret']);
         $this->forge->addKey('user_id');
         $this->forge->addForeignKey('user_id', $this->tables['users'], 'id', '', 'CASCADE');
-        $this->forge->createTable($this->tables['identities'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['identities']);
 
         /**
          * Auth Login Attempts Table
@@ -90,7 +88,7 @@ public function up(): void
         $this->forge->addKey(['id_type', 'identifier']);
         $this->forge->addKey('user_id');
         // NOTE: Do NOT delete the user_id or identifier when the user is deleted for security audits
-        $this->forge->createTable($this->tables['logins'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['logins']);
 
         /*
          * Auth Token Login Attempts Table
@@ -110,7 +108,7 @@ public function up(): void
         $this->forge->addKey(['id_type', 'identifier']);
         $this->forge->addKey('user_id');
         // NOTE: Do NOT delete the user_id or identifier when the user is deleted for security audits
-        $this->forge->createTable($this->tables['token_logins'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['token_logins']);
 
         /*
          * Auth Remember Tokens (remember-me) Table
@@ -128,7 +126,7 @@ public function up(): void
         $this->forge->addPrimaryKey('id');
         $this->forge->addUniqueKey('selector');
         $this->forge->addForeignKey('user_id', $this->tables['users'], 'id', '', 'CASCADE');
-        $this->forge->createTable($this->tables['remember_tokens'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['remember_tokens']);
 
         // Groups Users Table
         $this->forge->addField([
@@ -139,7 +137,7 @@ public function up(): void
         ]);
         $this->forge->addPrimaryKey('id');
         $this->forge->addForeignKey('user_id', $this->tables['users'], 'id', '', 'CASCADE');
-        $this->forge->createTable($this->tables['groups_users'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['groups_users']);
 
         // Users Permissions Table
         $this->forge->addField([
@@ -150,7 +148,7 @@ public function up(): void
         ]);
         $this->forge->addPrimaryKey('id');
         $this->forge->addForeignKey('user_id', $this->tables['users'], 'id', '', 'CASCADE');
-        $this->forge->createTable($this->tables['permissions_users'], $this->ifNotExists, $this->attributes);
+        $this->createTable($this->tables['permissions_users']);
     }
 
     // --------------------------------------------------------------------
@@ -169,4 +167,9 @@ public function down(): void
 
         $this->db->enableForeignKeyChecks();
     }
+
+    private function createTable(string $tableName): void
+    {
+        $this->forge->createTable($tableName, false, $this->attributes);
+    }
 }