Skip to content

Commit 5cfc8e2

Browse files
committed
fix rebase
1 parent 102561a commit 5cfc8e2

File tree

5 files changed

+27
-28
lines changed

5 files changed

+27
-28
lines changed

apps/codelab/src/app/components/angular-test-runner/angular-test-runner.component.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@ import {
1212
SimpleChanges,
1313
ViewChild,
1414
} from '@angular/core';
15-
import { createSystemJsSandbox } from '@codelab/code-demos/src/lib/shared/sandbox';
16-
import { ScriptLoaderService } from '@codelab/code-demos/src/lib/shared/script-loader.service';
17-
import { BehaviorSubject } from 'rxjs/internal/BehaviorSubject';
18-
import { Subscription } from 'rxjs/internal/Subscription';
19-
import { TestRunResult } from '@codelab/utils/src/lib/test-results/common';
15+
import { BehaviorSubject, Subscription } from 'rxjs';
2016
import { handleTestMessage } from './tests';
21-
import { addMetaInformation } from "@codelab/code-demos/src/lib/shared/helpers";
17+
import { ScriptLoaderService } from '@codelab/sandbox-runner';
18+
import { createSystemJsSandbox } from '@codelab/code-demos';
19+
import { TestRunResult } from '@codelab/utils';
20+
import { addMetaInformation } from '@codelab/code-demos';
2221

2322
@Component({
2423
selector: 'codelab-simple-angular-test-runner',

libs/code-demos/src/lib/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { CodeDemoModule } from './code-demo.module';
2-
1+
export { CodeDemoModule } from './code-demo.module';
2+
export { addMetaInformation } from './shared/helpers';
33
export { EditorFromModelComponent } from './multitab-editor/editor-from-model/editor-from-model.component';
44
export { MultitabEditorComponent } from './multitab-editor/multitab-editor.component';
55
export { FilePathComponent } from './file-path/file-path.component';

libs/sandbox-runner/src/lib/script-loader/script-loader.service.ts

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,30 @@ import { assert } from '@codelab/utils';
33

44
declare const require;
55

6+
const scripts = {
7+
mocha: require('!!raw-loader!./assets/js/mocha').default,
8+
chai: require('!!raw-loader!chai/chai').default,
9+
'test-bootstrap':
10+
require('!!raw-loader!./assets/js/test-bootstrap').default,
11+
zone: require('!!raw-loader!./assets/js/zone.js').default,
12+
reflectMetadata: require('!!raw-loader!reflect-metadata/Reflect.js').default,
13+
'mock-console':
14+
require('!!raw-loader!./assets/js/mock-console').default,
15+
// TODO(kirjs): not sure we still need vue and react libs
16+
// vue: require('!!raw-loader!vue/dist/vue.js').default,
17+
// react: require('!!raw-loader!react/umd/react.development.js').default,
18+
// 'react-dom': require('!!raw-loader!react-dom/umd/react-dom.development.js').default
19+
};
20+
21+
type ScriptName = keyof typeof scripts;
22+
623
@Injectable({
724
providedIn: 'root',
825
})
926
export class ScriptLoaderService {
10-
private readonly scripts = {
11-
mocha: require('!!raw-loader!./assets/js/mocha').default,
12-
chai: require('!!raw-loader!chai/chai').default,
13-
'test-bootstrap':
14-
require('!!raw-loader!./assets/js/test-bootstrap').default,
15-
shim: require('!!raw-loader!core-js/client/shim.min.js').default,
16-
zone: require('!!raw-loader!zone.js/dist/zone.js').default,
17-
// 'system-config':
18-
// require('!!raw-loader!../../../assets/runner/js/system-config').default,
19-
'mock-console':
20-
require('!!raw-loader!./assets/js/mock-console').default,
21-
// TODO(kirjs): not sure we still need vue and react libs
22-
// vue: require('!!raw-loader!vue/dist/vue.js').default,
23-
// react: require('!!raw-loader!react/umd/react.development.js').default,
24-
// 'react-dom': require('!!raw-loader!react-dom/umd/react-dom.development.js').default
25-
};
2627

27-
getScript(url) {
28-
assert(this.scripts[url]);
29-
return this.scripts[url];
28+
getScript(url: ScriptName) {
29+
assert(scripts[url]);
30+
return scripts[url];
3031
}
3132
}

libs/sandbox-runner/src/lib/test-runner.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export class TestRunner {
3535
private readonly code = {
3636
mocha: this.scriptLoaderService.getScript('mocha'),
3737
chai: this.scriptLoaderService.getScript('chai'),
38-
SystemJS: this.scriptLoaderService.getScript('SystemJS'),
3938
polyfill: `const window = globalThis;`,
4039
mochaSetup: `mocha.setup('bdd').reporter(function(a) {});`,
4140
mochaRun: mochaRun,

0 commit comments

Comments
 (0)