Refactor isFutureDate and isPastDate validators to handle invalid referenceDate with error throwing; remove outdated test cases for invalid referenceDate fallback.

Author: ogroppo

src/validators/isFutureDate.test.ts

@@ -48,17 +48,5 @@ describe("isFutureDate", () => {
         false
       );
     });
-
-    it("should fall back to current date when referenceDate is invalid", () => {
-      const futureDate = new Date();
-      futureDate.setFullYear(futureDate.getFullYear() + 1);
-
-      expect(isFutureDate(futureDate, { referenceDate: "invalid-date" })).toBe(
-        true
-      );
-      expect(isFutureDate(futureDate, { referenceDate: null as any })).toBe(
-        true
-      );
-    });
   });
 });

src/validators/isFutureDate.ts

@@ -7,5 +7,9 @@ export const isFutureDate = (
 ): boolean => {
   const date = parseDate(arg);
 
-  return !!date && date > (parseDate(referenceDate) ?? new Date());
+  const reference = referenceDate ? parseDate(referenceDate) : new Date();
+  if (!reference)
+    throw new Error(`[isFutureDate] Invalid referenceDate: ${referenceDate}`);
+
+  return !!date && date > reference;
 };

src/validators/isPastDate.test.ts

@@ -43,15 +43,5 @@ describe("isPastDate", () => {
         false
       );
     });
-
-    it("should fall back to current date when referenceDate is invalid", () => {
-      const pastDate = new Date();
-      pastDate.setFullYear(pastDate.getFullYear() - 1);
-
-      expect(isPastDate(pastDate, { referenceDate: "invalid-date" })).toBe(
-        true
-      );
-      expect(isPastDate(pastDate, { referenceDate: null as any })).toBe(true);
-    });
   });
 });

src/validators/isPastDate.ts

@@ -7,5 +7,9 @@ export const isPastDate = (
 ): boolean => {
   const date = parseDate(arg);
 
-  return !!date && date < (parseDate(referenceDate) ?? new Date());
+  const reference = referenceDate ? parseDate(referenceDate) : new Date();
+  if (!reference)
+    throw new Error(`[isPastDate] Invalid referenceDate: ${referenceDate}`);
+
+  return !!date && date < reference;
 };