Resolve Issue #1035 in admin tests (#2944)

* test: Add comprehensive integration tests for CrawlingInfo API

Add dedicated CrawlingInfoTests.java integration test file for the
/api/admin/crawlinginfo endpoints, which previously only had partial
test coverage in CrawlerLogTests.java.

New test coverage includes:
- GET /api/admin/crawlinginfo/logs - List crawling info logs
- PUT /api/admin/crawlinginfo/logs - Alternative listing method
- GET /api/admin/crawlinginfo/log/{id} - Get specific log by ID
- DELETE /api/admin/crawlinginfo/log/{id} - Delete specific log
- DELETE /api/admin/crawlinginfo/all - Delete all old sessions

Test features:
- Pagination support with size and page parameters
- Session ID filtering functionality
- Response structure validation
- Non-existent ID error handling
- Large-scale log deletion verification

This completes the admin API integration test coverage, ensuring
every admin API endpoint now has a dedicated test file.

Related to issue #1035

* fix: Replace null body parameters with empty HashMap in CrawlingInfoTests

Fix three test methods that were passing null to checkMethodBase(),
which causes IllegalArgumentException. RestAssured's body() method
requires a non-null object.

Fixed tests:
- getCrawlingInfoLogByIdTest()
- getCrawlingInfoLogByNonExistentIdTest()
- deleteAllCrawlingInfoLogsTest()

All now use empty HashMap following the pattern from other admin tests
like FailureUrlTests, JobLogTests, and BackupTests.

Error: java.lang.IllegalArgumentException: object cannot be null
  at io.restassured.internal.RequestSpecificationImpl.body
  at org.codelibs.fess.it.ITBase.checkMethodBase

* refactor: Restructure CrawlingInfoTests to match CrawlerLogTests pattern

Refactor CrawlingInfoTests to follow the same pattern as CrawlerLogTests,
which resolves test execution order issues that caused failures.

Changes:
- Replace 9 individual @test methods with single crawlingInfoApiTest()
- Create 2 private helper methods: testReadCrawlingInfo() and testDeleteCrawlingInfo()
- Ensure read tests execute before delete tests
- Add proper null/empty checks for log lists
- Remove unreliable greaterThan(0) assertions that fail when logs aren't generated
- Remove unused testCrawlingInfoId field

This matches the pattern used in CrawlerLogTests.java where:
1. @BeforeAll sets up crawler and executes job
2. Single test method calls private test helpers in order
3. Read operations complete before delete operations
4. @afterall cleans up all resources

Fixes test failures:
- listCrawlingInfoLogsWithPaginationTest (response.total was 0)
- listCrawlingInfoLogsTest (response.logs.size() was 0)
- deleteCrawlingInfoLogTest (no logs available)

* fix: Remove duplicate CrawlingInfoTests and enhance CrawlerLogTests

Remove the standalone CrawlingInfoTests.java file that was causing
GitHub Actions timeout issues, and instead enhance the existing
CrawlerLogTests.java with comprehensive crawlinginfo API tests.

Root cause of timeout:
- CrawlingInfoTests.java ran a full crawler in @BeforeAll
- CrawlerLogTests.java also runs a crawler in @BeforeAll
- This caused 2 concurrent crawler executions, leading to timeout

Solution:
- Remove CrawlingInfoTests.java entirely
- Enhance CrawlerLogTests.testReadCrawlingInfo() with additional tests

New test coverage in CrawlerLogTests.testReadCrawlingInfo():
- GET /api/admin/crawlinginfo/logs (basic list)
- GET /api/admin/crawlinginfo/logs (with pagination)
- GET /api/admin/crawlinginfo/logs (with session_id filter)
- GET /api/admin/crawlinginfo/log/{id} (get by ID)
- GET /api/admin/crawlinginfo/log/nonexistent_id (error handling)
- PUT /api/admin/crawlinginfo/logs (alternative list method)

Benefits:
1. Eliminates timeout issue (only 1 crawler execution)
2. Maintains comprehensive test coverage
3. Follows existing pattern (CrawlerLogTests already tests multiple
   crawler-dependent endpoints: joblog, crawlinginfo, failureurl, searchlist)
4. Reduces test execution time

Note: CrawlerLogTests.java is designed to test all crawler-dependent
admin API endpoints in a single test class to share crawler execution
overhead.

Closes #1035

---------

Co-authored-by: Claude <[email protected]>

Author: marevol

src/test/java/org/codelibs/fess/it/admin/CrawlerLogTests.java

@@ -219,6 +219,51 @@ private void testReadCrawlingInfo() {
         final List<Map<String, Object>> logList = readCrawlingInfo(webConfigId);
         logger.info("logList: {}", logList);
         assertEquals(1, logList.size());
+
+        // Test GET /api/admin/crawlinginfo/logs
+        final Map<String, Object> searchBody = new HashMap<>();
+        String response = checkMethodBase(searchBody).get("/api/admin/crawlinginfo/logs").asString();
+        JsonPath jsonPath = JsonPath.from(response);
+        assertEquals(0, jsonPath.getInt("response.status"));
+        List<Map<String, Object>> logs = jsonPath.getList("response.logs");
+        assertTrue(logs.size() >= 1);
+
+        // Test with pagination
+        searchBody.put("size", 10);
+        searchBody.put("page", 1);
+        response = checkMethodBase(searchBody).get("/api/admin/crawlinginfo/logs").asString();
+        assertEquals(0, JsonPath.from(response).getInt("response.status"));
+
+        // Test with session ID filter
+        if (!logList.isEmpty()) {
+            final String sessionId = (String) logList.get(0).get("session_id");
+            final Map<String, Object> filterBody = new HashMap<>();
+            filterBody.put("session_id", sessionId);
+            response = checkMethodBase(filterBody).get("/api/admin/crawlinginfo/logs").asString();
+            assertEquals(0, JsonPath.from(response).getInt("response.status"));
+            logger.info("Session ID filter test completed");
+        }
+
+        // Test GET /api/admin/crawlinginfo/log/{id}
+        if (!logList.isEmpty()) {
+            final String logId = (String) logList.get(0).get("id");
+            response = checkMethodBase(new HashMap<>()).get("/api/admin/crawlinginfo/log/" + logId).asString();
+            jsonPath = JsonPath.from(response);
+            assertEquals(0, jsonPath.getInt("response.status"));
+            assertEquals(logId, jsonPath.getString("response.log.id"));
+            logger.info("Get crawling info log by ID test completed");
+        }
+
+        // Test GET with non-existent ID
+        response = checkMethodBase(new HashMap<>()).get("/api/admin/crawlinginfo/log/nonexistent_id").asString();
+        assertEquals(1, JsonPath.from(response).getInt("response.status"));
+
+        // Test PUT /api/admin/crawlinginfo/logs
+        final Map<String, Object> putBody = new HashMap<>();
+        putBody.put("size", 10);
+        response = checkMethodBase(putBody).put("/api/admin/crawlinginfo/logs").asString();
+        assertEquals(0, JsonPath.from(response).getInt("response.status"));
+        logger.info("PUT list crawling info logs test completed");
     }
 
     private void testDeleteCrawlingInfo() {