Fix ProcessHelperTest timing issues by using long-running processes

Fixed two failing tests that were using 'echo' commands which complete
almost instantly, making it impossible to verify process running state:

1. test_startProcess_replaceExistingProcess:
   - Changed from 'echo' to 'sleep 10' commands
   - Added proper wait time before checking process state
   - Added verification that only one process exists for the session

2. test_destroyProcess_withRunningProcess:
   - Changed from 'echo' to 'sleep 10' command
   - Simplified polling logic - just wait 100ms for process to start
   - Updated exit code assertion (forcibly destroyed processes may have non-zero exit codes)

These changes ensure the tests can reliably verify that processes are running
before attempting to check their state or destroy them.

Author: claude

src/test/java/org/codelibs/fess/helper/ProcessHelperTest.java

@@ -149,8 +149,9 @@ public void test_startProcess_invalidCommand() {
 
     public void test_startProcess_replaceExistingProcess() {
         String sessionId = "test_replace";
-        List<String> cmdList1 = Arrays.asList("echo", "first");
-        List<String> cmdList2 = Arrays.asList("echo", "second");
+        // Use sleep commands that run longer so we can verify they're running
+        List<String> cmdList1 = Arrays.asList("sleep", "10");
+        List<String> cmdList2 = Arrays.asList("sleep", "10");
         Consumer<ProcessBuilder> pbCall = pb -> {
             pb.redirectErrorStream(true);
         };
@@ -159,15 +160,22 @@ public void test_startProcess_replaceExistingProcess() {
             // Start first process
             JobProcess jobProcess1 = processHelper.startProcess(sessionId, cmdList1, pbCall);
             assertNotNull(jobProcess1);
+
+            // Wait for first process to be running
+            Thread.sleep(100);
             assertTrue(processHelper.isProcessRunning(sessionId));
 
             // Start second process with same session ID (should replace first)
             JobProcess jobProcess2 = processHelper.startProcess(sessionId, cmdList2, pbCall);
             assertNotNull(jobProcess2);
-            assertTrue(processHelper.isProcessRunning(sessionId));
 
-            // Wait a bit for the processes to complete
+            // Wait for second process to be running
             Thread.sleep(100);
+            assertTrue(processHelper.isProcessRunning(sessionId));
+
+            // Verify we still have only one process for this session
+            Set<String> sessionIds = processHelper.getRunningSessionIdSet();
+            assertEquals(1, sessionIds.stream().filter(id -> id.equals(sessionId)).count());
 
             // Clean up
             processHelper.destroyProcess(sessionId);
@@ -211,7 +219,8 @@ public void test_multipleProcesses() {
 
     public void test_destroyProcess_withRunningProcess() {
         String sessionId = "test_destroy";
-        List<String> cmdList = Arrays.asList("echo", "hello");
+        // Use sleep command that runs longer so we can verify it's running
+        List<String> cmdList = Arrays.asList("sleep", "10");
         Consumer<ProcessBuilder> pbCall = pb -> {
             pb.redirectErrorStream(true);
         };
@@ -220,26 +229,18 @@ public void test_destroyProcess_withRunningProcess() {
             JobProcess jobProcess = processHelper.startProcess(sessionId, cmdList, pbCall);
             assertNotNull(jobProcess);
 
-            // Poll for process to be running (max 50 times, 100ms interval)
-            boolean isRunning = false;
-            for (int i = 0; i < 50; i++) {
-                if (processHelper.isProcessRunning(sessionId)) {
-                    isRunning = true;
-                    break;
-                }
-                Thread.sleep(100);
-            }
-            assertTrue("Process did not become running within timeout", isRunning);
+            // Wait for process to start
+            Thread.sleep(100);
 
-            // Wait a bit for the process to start
-            Thread.sleep(50);
+            // Verify process is running
+            assertTrue("Process did not become running within timeout", processHelper.isProcessRunning(sessionId));
 
             // Destroy the process
             int exitCode = processHelper.destroyProcess(sessionId);
             assertFalse(processHelper.isProcessRunning(sessionId));
 
-            // Exit code should be 0 or -1 depending on timing
-            assertTrue(exitCode == 0 || exitCode == -1);
+            // Exit code should be non-zero for forcibly destroyed process, or -1
+            assertTrue(exitCode != 0 || exitCode == -1);
         } catch (Exception e) {
             fail("Unexpected exception: " + e.getMessage());
         }