Merge pull request #156 from codelitdev:rajat1saxena/issue153

Uploading a gif file crashes the server

Author: rajat1saxena

apps/api/src/config/constants.ts

@@ -26,7 +26,7 @@ export const APIKEY_RESTRICTION_REFERRER = "referrer";
 export const APIKEY_RESTRICTION_IP = "ipaddress";
 export const APIKEY_RESTRICTION_CUSTOM = "custom";
 export const imagePattern = /^image\/(jpe?g|png)$/;
-export const imagePatternIncludingGif = /^image\/(jpe?g|png|gif|webp)$/;
+export const imagePatternForThumbnailGeneration = /^image\/(jpe?g|png|webp)$/;
 export const videoPattern = /video/;
 export const thumbnailWidth = 120;
 export const thumbnailHeight = 69;

apps/api/src/media/service.ts

@@ -5,7 +5,7 @@ import {
     tempFileDirForUploads,
     imagePattern,
     videoPattern,
-    imagePatternIncludingGif,
+    imagePatternForThumbnailGeneration,
     USE_CLOUDFRONT,
 } from "../config/constants";
 import imageUtils from "@medialit/images";
@@ -55,7 +55,7 @@ const generateAndUploadThumbnail = async ({
     const thumbPath = `${workingDirectory}/thumb.webp`;
 
     let isThumbGenerated = false; // to indicate if the thumbnail name is to be saved to the DB
-    if (imagePatternIncludingGif.test(mimetype)) {
+    if (imagePatternForThumbnailGeneration.test(mimetype)) {
         await thumbnail.forImage(originalFilePath, thumbPath);
         isThumbGenerated = true;
     }