Skip to content

Commit 0d3888a

Browse files
author
Saurabh Sinha
committed
Added signature field to Callable; broadened handled exception types for expression resolution
Signed-off-by: Saurabh Sinha <[email protected]>
1 parent 29c918b commit 0d3888a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/main/java/com/ibm/northstar/SymbolTable.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,9 @@ private static Pair<String, Callable> processCallableDeclaration(CallableDeclara
252252
List<String> classFields, String typeName) {
253253
Callable callableNode = new Callable();
254254

255+
// add callable signature
256+
callableNode.setSignature(callableDecl.getSignature().asString());
257+
255258
// add comment associated with method/constructor
256259
callableNode.setComment(callableDecl.getComment().isPresent() ? callableDecl.getComment().get().asString() : "");
257260

@@ -435,7 +438,7 @@ private static String resolveExpression(Expression expression) {
435438
if (resolvedType.isReferenceType() || resolvedType.isUnionType()) {
436439
return resolvedType.describe();
437440
}
438-
} catch (UnsolvedSymbolException | IllegalStateException exception) {
441+
} catch (RuntimeException exception) {
439442
Log.warn("Could not resolve expression: "+expression+"\n"+exception.getMessage());
440443
}
441444
return "";

src/main/java/com/ibm/northstar/entities/Callable.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
@Data
88
public class Callable {
9+
private String signature;
910
private String comment;
1011
private List<String> annotations;
1112
private List<String> modifiers;

0 commit comments

Comments
 (0)