Refactor Integration Tests.

Signed-off-by: Rahul Krishna <[email protected]>

Author: rahlk

src/test/java/com/ibm/cldk/CodeAnalyzerIntegrationTest.java

@@ -7,6 +7,7 @@
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.junit.jupiter.Container;
 import org.testcontainers.junit.jupiter.Testcontainers;
+import org.testcontainers.utility.MountableFile;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -16,6 +17,8 @@
 import java.text.MessageFormat;
 import java.util.Properties;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
 @Testcontainers
 @SuppressWarnings("resource")
 public class CodeAnalyzerIntegrationTest {
@@ -46,7 +49,19 @@ public class CodeAnalyzerIntegrationTest {
             .withFileSystemBind(
                     String.valueOf(Paths.get(System.getProperty("user.dir")).resolve("build/libs")),
                     "/opt/jars",
-                    BindMode.READ_WRITE);
+                    BindMode.READ_WRITE)
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("build/libs")), "/opt/jars")
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("src/test/resources/test-applications/mvnw-corrupt-test")), "/test-applications/mvnw-corrupt-test")
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("src/test/resources/test-applications/mvnw-working-test")), "/test-applications/mvnw-working-test");
+
+    @Container
+    static final GenericContainer<?> mavenContainer = new GenericContainer<>("maven:3.8.3-openjdk-17")
+            .withCreateContainerCmdModifier(cmd -> cmd.withEntrypoint("sh"))
+            .withCommand("-c", "while true; do sleep 1; done")
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("build/libs")), "/opt/jars")
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("src/test/resources/test-applications/mvnw-corrupt-test")), "/test-applications/mvnw-corrupt-test")
+            .withCopyFileToContainer(MountableFile.forHostPath(Paths.get(System.getProperty("user.dir")).resolve("src/test/resources/test-applications/mvnw-working-test")), "/test-applications/mvnw-working-test");
+
 
     @BeforeAll
     static void setUp() {
@@ -73,7 +88,8 @@ void shouldHaveCodeAnalyzerJar() throws Exception {
         Assertions.assertTrue(dirContents.getStdout().contains("codeanalyzer"), "Codeanalyzer.jar not found in the container.");
     }
 
-    @Test void shouldBeAbleToRunCodeAnalyzer() throws Exception {
+    @Test
+    void shouldBeAbleToRunCodeAnalyzer() throws Exception {
         var runCodeAnalyzerJar = container.execInContainer(
                 "java",
                 "-jar",
@@ -84,5 +100,50 @@ void shouldHaveCodeAnalyzerJar() throws Exception {
         Assertions.assertEquals(0, runCodeAnalyzerJar.getExitCode(),
                 "Command should execute successfully");
         Assertions.assertTrue(runCodeAnalyzerJar.getStdout().length() > 0,
-                "Should have some output");    }
+                "Should have some output");
+    }
+
+    @Test
+    void corruptMavenShouldNotBuildWithWrapper() throws IOException, InterruptedException {
+        // Make executable
+        mavenContainer.execInContainer("chmod", "+x", "/test-applications/mvnw-corrupt-test/mvnw");
+        // Let's start by building the project by itself
+        var mavenProjectBuildWithWrapper = mavenContainer.withWorkingDirectory("/test-applications/mvnw-corrupt-test").execInContainer("/test-applications/mvnw-corrupt-test/mvnw", "clean", "compile");
+        Assertions.assertNotEquals(0, mavenProjectBuildWithWrapper.getExitCode());
+    }
+
+//    @Test
+//    void corruptMavenShouldProduceAnalysisArtifactsWhenMVNCommandIsInPath() throws IOException, InterruptedException {
+//        // Let's start by building the project by itself
+//        var corruptMavenProjectBuild = mavenContainer.withWorkingDirectory("/test-applications/mvnw-corrupt-test").execInContainer("mvn", "-f", "/test-applications/mvnw-corrupt-test/pom.xml", "clean", "compile");
+//        Assertions.assertEquals(0, corruptMavenProjectBuild.getExitCode(), "Failed to build the project with system's default Maven.");
+//        // NOw run codeanalyzer and assert if analysis.json is generated.
+//        mavenContainer.execInContainer("java", "-jar", String.format("/opt/jars/codeanalyzer-%s.jar", codeanalyzerVersion), "--input=/test-applications/mvnw-corrupt-test", "--output=/tmp/", "--analysis-level=2", "--no-build");
+//        var codeAnalyzerOutputDirContents = mavenContainer.execInContainer("ls", "/tmp/analysis.json");
+//        String codeAnalyzerOutputDirContentsStdOut = codeAnalyzerOutputDirContents.getStdout();
+//        Assertions.assertTrue(codeAnalyzerOutputDirContentsStdOut.length() > 0, "Could not find 'analysis.json'.");
+//        Assertions.assertTrue(codeAnalyzerOutputDirContentsStdOut.contains("Building the project using") && codeAnalyzerOutputDirContentsStdOut.contains("/mvn."));
+//        Assertions.assertFalse(codeAnalyzerOutputDirContentsStdOut.contains("Building the project using") && codeAnalyzerOutputDirContentsStdOut.contains("/test-applications/mvnw-corrupt-test/mvnw."));
+//    }
+//
+//    @Test
+//    void corruptMavenShouldNotTerminateWithErrorWhenMavenIsNotPresentUnlessAnalysisLevel2() throws IOException, InterruptedException {
+//        // When analysis level 2, we should get a Runtime Exception
+//        assertThrows(RuntimeException.class, () ->
+//                container.execInContainer(
+//                        "java",
+//                        "-jar",
+//                        String.format("/opt/jars/codeanalyzer-%s.jar", codeanalyzerVersion),
+//                        "--input=/test-applications/mvnw-corrupt-test",
+//                        "--output=/tmp/",
+//                        "--analysis-level=2"
+//                )
+//        );
+//        // When analysis level is 1, we should still be able to generate an analysis.json file.
+//        container.execInContainer("java", "-jar", String.format("/opt/jars/codeanalyzer-%s.jar", codeanalyzerVersion), "--input=/test-applications/mvnw-corrupt-test", "--output=/tmp/", "--analysis-level=1");
+//        var codeAnalyzerOutputDirContents = container.execInContainer("ls", "/tmp/analysis.json");
+//        String codeAnalyzerOutputDirContentsStdOut = codeAnalyzerOutputDirContents.getStdout();
+//        Assertions.assertTrue(codeAnalyzerOutputDirContentsStdOut.length() > 0, "Could not find 'analysis.json'.");
+//        Assertions.assertTrue(codeAnalyzerOutputDirContentsStdOut.contains("Could not find Maven or a valid Maven Wrapper"));
+//    }
 }