Update core.py to match python analysis signature.

Signed-off-by: Rahul Krishna <[email protected]>

Author: rahlk

cldk/analysis/python/python_analysis.py

@@ -30,17 +30,11 @@ class PythonAnalysis:
 
     def __init__(
         self,
-        eager_analysis: bool,
         project_dir: str | Path | None,
         source_code: str | None,
-        analysis_backend_path: str | None,
-        analysis_json_path: str | Path | None,
     ) -> None:
         self.project_dir = project_dir
         self.source_code = source_code
-        self.analysis_json_path = analysis_json_path
-        self.analysis_backend_path = analysis_backend_path
-        self.eager_analysis = eager_analysis
         self.analysis_backend: TreesitterPython = TreesitterPython()
 
     def get_methods(self) -> List[PyMethod]:

cldk/core.py

@@ -27,6 +27,7 @@
 from cldk.analysis.c import CAnalysis
 from cldk.analysis.java import JavaAnalysis
 from cldk.analysis.commons.treesitter import TreesitterJava
+from cldk.analysis.python.python_analysis import PythonAnalysis
 from cldk.utils.exceptions import CldkInitializationException
 from cldk.utils.sanitization.java import TreesitterSanitizer
 
@@ -118,6 +119,11 @@ def analysis(
                 target_files=target_files,
                 eager_analysis=eager,
             )
+        elif self.language == "python":
+            return PythonAnalysis(
+                project_dir=project_path,
+                source_code=source_code,
+            )
         elif self.language == "c":
             return CAnalysis(project_dir=project_path)
         else:

tests/analysis/python/test_python_analysis.py

@@ -67,7 +67,7 @@ def divide(self, a, b):
 
 def test_get_methods():
     """Should return all of the methods"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     all_methods = python_analysis.get_methods()
     assert all_methods is not None
@@ -79,7 +79,7 @@ def test_get_methods():
 
 def test_get_functions():
     """Should return all of the functions"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     all_functions = python_analysis.get_functions()
     assert all_functions is not None
@@ -91,7 +91,7 @@ def test_get_functions():
 
 def test_get_all_modules(tmp_path):
     """Should return all of the modules"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=tmp_path, source_code=None, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=tmp_path, source_code=None)
 
     # set up some temporary modules
     temp_file_path = os.path.join(tmp_path, "hello.py")
@@ -111,7 +111,7 @@ def test_get_all_modules(tmp_path):
 
 def test_get_method_details():
     """Should return the method details"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     method_details = python_analysis.get_method_details("add(self, a, b)")
     assert method_details is not None
@@ -121,7 +121,7 @@ def test_get_method_details():
 
 def test_is_parsable():
     """Should be able to parse the code"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     code = "def is_parsable(self, code: str) -> bool: return True"
     is_parsable = python_analysis.is_parsable(code)
@@ -134,7 +134,7 @@ def test_is_parsable():
 
 def test_get_raw_ast():
     """Should return the raw AST"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     raw_ast = python_analysis.get_raw_ast(PYTHON_CODE)
     assert raw_ast is not None
@@ -144,7 +144,7 @@ def test_get_raw_ast():
 
 def test_get_imports():
     """Should return all of the imports"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     all_imports = python_analysis.get_imports()
     assert all_imports is not None
@@ -156,7 +156,7 @@ def test_get_imports():
 
 def test_get_variables():
     """Should return all of the variables"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_variables()
@@ -165,7 +165,7 @@ def test_get_variables():
 
 def test_get_classes():
     """Should return all of the classes"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     all_classes = python_analysis.get_classes()
     assert all_classes is not None
@@ -178,7 +178,7 @@ def test_get_classes():
 
 def test_get_classes_by_criteria():
     """Should return all of the classes that match the criteria"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_classes_by_criteria()
@@ -187,7 +187,7 @@ def test_get_classes_by_criteria():
 
 def test_get_sub_classes():
     """Should return all of the subclasses"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_sub_classes()
@@ -196,7 +196,7 @@ def test_get_sub_classes():
 
 def test_get_nested_classes():
     """Should return all of the nested classes"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_nested_classes()
@@ -205,7 +205,7 @@ def test_get_nested_classes():
 
 def test_get_constructors():
     """Should return all of the constructors"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_constructors()
@@ -214,7 +214,7 @@ def test_get_constructors():
 
 def test_get_methods_in_class():
     """Should return all of the methods in the class"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_methods_in_class()
@@ -223,7 +223,7 @@ def test_get_methods_in_class():
 
 def test_get_fields():
     """Should return all of the fields in the class"""
-    python_analysis = PythonAnalysis(eager_analysis=True, project_dir=None, source_code=PYTHON_CODE, analysis_backend_path=None, analysis_json_path=None)
+    python_analysis = PythonAnalysis(project_dir=None, source_code=PYTHON_CODE)
 
     with pytest.raises(NotImplementedError) as except_info:
         python_analysis.get_fields()