Skip to content

Commit 991fd8b

Browse files
committed
Updated test cases corresponding to change in method signature format
Signed-off-by: Saurabh Sinha <[email protected]>
1 parent e68d262 commit 991fd8b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/analysis/java/test_jcodeanalyzer.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ def test_get_all_callers(test_fixture, analysis_json):
342342
)
343343

344344
# Call without using symbol table
345-
all_callers = code_analyzer.get_all_callers("com.ibm.websphere.samples.daytrader.util.Log", "log(String)", False)
345+
all_callers = code_analyzer.get_all_callers("com.ibm.websphere.samples.daytrader.util.Log", "log(java.lang.String)", False)
346346
assert all_callers is not None
347347
assert isinstance(all_callers, Dict)
348348
assert len(all_callers) > 0
@@ -355,7 +355,7 @@ def test_get_all_callers(test_fixture, analysis_json):
355355

356356
# TODO: This currently doesn't work. Code has bad call as seen in this error message:
357357
# TypeError: TreesitterJava.get_calling_lines() missing 1 required positional argument: 'is_target_method_a_constructor'
358-
all_callers = code_analyzer.get_all_callers("com.ibm.websphere.samples.daytrader.util.Log", "log(String)", True)
358+
all_callers = code_analyzer.get_all_callers("com.ibm.websphere.samples.daytrader.util.Log", "log(java.lang.String)", True)
359359
assert all_callers is not None
360360
assert isinstance(all_callers, Dict)
361361
assert "caller_details" in all_callers
@@ -378,7 +378,7 @@ def test_get_all_callees(test_fixture, analysis_json):
378378
)
379379

380380
# Call without using symbol table
381-
all_callees = code_analyzer.get_all_callees("com.ibm.websphere.samples.daytrader.util.Log", "printCollection(String, Collection)", False)
381+
all_callees = code_analyzer.get_all_callees("com.ibm.websphere.samples.daytrader.util.Log", "printCollection(java.lang.String, java.util.Collection)", False)
382382
assert all_callees is not None
383383
assert isinstance(all_callees, Dict)
384384
assert "callee_details" in all_callees
@@ -388,7 +388,7 @@ def test_get_all_callees(test_fixture, analysis_json):
388388

389389
# TODO: Throws the following exception
390390
# TypeError: TreesitterJava.get_calling_lines() missing 1 required positional argument: 'is_target_method_a_constructor'
391-
all_callees = code_analyzer.get_all_callees("com.ibm.websphere.samples.daytrader.util.Log", "printCollection(String, Collection)", True)
391+
all_callees = code_analyzer.get_all_callees("com.ibm.websphere.samples.daytrader.util.Log", "printCollection(java.lang.String, java.util.Collection)", True)
392392
assert all_callees is not None
393393
assert isinstance(all_callees, Dict)
394394
assert "callee_details" in all_callees
@@ -458,7 +458,7 @@ def test_get_method(test_fixture, analysis_json):
458458
target_files=None,
459459
)
460460

461-
method = code_analyzer.get_method("com.ibm.websphere.samples.daytrader.impl.direct.TradeDirect", "publishQuotePriceChange(QuoteDataBean, BigDecimal, BigDecimal, double)")
461+
method = code_analyzer.get_method("com.ibm.websphere.samples.daytrader.impl.direct.TradeDirect", "publishQuotePriceChange(com.ibm.websphere.samples.daytrader.entities.QuoteDataBean, java.math.BigDecimal, java.math.BigDecimal, double)")
462462
assert method is not None
463463
assert isinstance(method, JCallable)
464464

@@ -730,7 +730,7 @@ def test_get_class_call_graph(test_fixture, analysis_json):
730730

731731
# Call with method signature
732732
class_call_graph = code_analyzer.get_class_call_graph(
733-
"com.ibm.websphere.samples.daytrader.impl.direct.TradeDirect", "createHolding(Connection, int, String, double, BigDecimal)"
733+
"com.ibm.websphere.samples.daytrader.impl.direct.TradeDirect", "createHolding(java.sql.Connection, int, java.lang.String, double, java.math.BigDecimal)"
734734
)
735735
assert class_call_graph is not None
736736
assert isinstance(class_call_graph, List)

0 commit comments

Comments
 (0)