System.getenv()["CI"] true even on github action, any way to differenciate?

[ChauCM]

Use case

if (System.getenv()["CI"]) { // CI=true is exported by Codemagic
                storeFile file(System.getenv()["CM_KEYSTORE_PATH"])
                storePassword System.getenv()["CM_KEYSTORE_PASSWORD"]
                keyAlias System.getenv()["CM_KEY_ALIAS"]
                keyPassword System.getenv()["CM_KEY_PASSWORD"]
            } 
            else if (System.getenv("ANDROID_KEYSTORE_PATH")) { // github action
                storeFile file(System.getenv("ANDROID_KEYSTORE_PATH"))
                keyAlias System.getenv("ANDROID_KEYSTORE_ALIAS")
                keyPassword System.getenv("ANDROID_KEYSTORE_PRIVATE_KEY_PASSWORD")
                storePassword System.getenv("ANDROID_KEYSTORE_PASSWORD")
            } else {
                keyAlias keystoreProperties['keyAlias']
                keyPassword keystoreProperties['keyPassword']
                storeFile keystoreProperties['storeFile'] ? file(keystoreProperties['storeFile']) : null
                storePassword keystoreProperties['storePassword']
            }
        }

It will also run this part even in github action

                storeFile file(System.getenv()["CM_KEYSTORE_PATH"])
                storePassword System.getenv()["CM_KEYSTORE_PASSWORD"]
                keyAlias System.getenv()["CM_KEY_ALIAS"]
                keyPassword System.getenv()["CM_KEY_PASSWORD"]

Idea

Is there a better condition to make sure the first part run only in Codemagic?

[kulakarla]

Hello @ChauCM

You could utilize GitHub actions default environment variables, like GITHUB_ACTIONS, which is always set to true when GH actions is running the workflow.
A simple solution here would be just to wrap a simple boolean if around the code you don't want to run on GH actions, like this:

if(!System.getenv()["GITHUB_ACTIONS"]){
      storeFile file(System.getenv()["CM_KEYSTORE_PATH"])
      storePassword System.getenv()["CM_KEYSTORE_PASSWORD"]
      keyAlias System.getenv()["CM_KEY_ALIAS"]
      keyPassword System.getenv()["CM_KEY_PASSWORD"]
}

Take a look at GitHub Docs for Actions' Environment Variables and hopefully you get everything resolved.

[kulakarla]

I'm tenatively closing this thread due to no response.