🛀 update Sizzle to latest and hardcode it as the sole selector engine

Author: codemasher

Rakefile

@@ -17,7 +17,7 @@ module PrototypeHelper
   TMP_DIR       = File.join(TEST_UNIT_DIR, 'tmp')
   VERSION       = YAML.load(IO.read(File.join(SRC_DIR, 'constants.yml')))['PROTOTYPE_VERSION']
 
-  DEFAULT_SELECTOR_ENGINE = 'sizzle'
+#  DEFAULT_SELECTOR_ENGINE = 'sizzle'
 
   host = RbConfig::CONFIG['host']
   IS_WINDOWS = host.include?('mswin') || host.include?('mingw32')
@@ -245,7 +245,7 @@ task :dist do
   PrototypeHelper.sprocketize(
     :path => 'src',
     :source => 'prototype.js',
-    :selector_engine => ENV['SELECTOR_ENGINE'] || PrototypeHelper::DEFAULT_SELECTOR_ENGINE
+#    :selector_engine => ENV['SELECTOR_ENGINE'] || PrototypeHelper::DEFAULT_SELECTOR_ENGINE
   )
 end
 

src/prototype/dom.js

@@ -2,7 +2,7 @@
 //= require "dom/dom"
 //= require "dom/layout"
 //= require "dom/selector"
-//= require <selector_engine>
+//= require "dom/selector_engine"
 //= require "dom/form"
 //= require "dom/event"
 

vendor/sizzle/selector_engine.js renamed to src/prototype/dom/selector_engine.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 Prototype._original_property = window.Sizzle;
 
 ;(function () {
@@ -15,7 +16,7 @@ Prototype._original_property = window.Sizzle;
   }
 })();
 
-//= require "repository/dist/sizzle"
+//= require "../../../vendor/sizzle/sizzle"
 
 ;(function() {
   if (typeof Sizzle !== 'undefined') {
@@ -46,7 +47,7 @@ Prototype._original_property = window.Sizzle;
   }
 
   function match(element, selector) {
-    return engine.matches(selector, [element]).length == 1;
+    return engine.matches(selector, [element]).length === 1;
   }
 
   Prototype.Selector.engine = engine;

test/unit/tests/selector.test.js

@@ -74,11 +74,14 @@ suite('Selector', function () {
     assert.enumEqual([$('item_3')], $$('li#item_3[class]'), 'li#item_3[class]');
   });
 
+  // Unescaped # errors out with "Syntax error, unrecognized expression"
+  // https://github.com/jquery/jquery/issues/2824
   test('tag + attr equality (a[href="#"])', function () {
-    assert.enumEqual($('link_1', 'link_2', 'link_3'), $$('#fixtures a[href="#"]'));
-    assert.enumEqual($('link_1', 'link_2', 'link_3'), $$('#fixtures a[href=#]'));
+    assert.enumEqual($('link_1', 'link_2', 'link_3'), $$('#fixtures a[href="\\#"]'));
+    assert.enumEqual($('link_1', 'link_2', 'link_3'), $$('#fixtures a[href=\\#]'));
   });
 
+
   test('tag + attr whitespace-tokenized (a[class~="internal"])', function () {
     assert.enumEqual($('link_1', 'link_2'), $$('a[class~="internal"]'), "a[class~=\"internal\"]");
     assert.enumEqual($('link_1', 'link_2'), $$('a[class~=internal]'), "a[class~=internal]");