Skip to content

Commit 548580c

Browse files
Fix issue with Element.visible reading only inline style. [closes prototypejs#131]
1 parent d9411e5 commit 548580c

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

src/prototype/dom/dom.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@
290290
* // -> true
291291
**/
292292
function visible(element) {
293-
return $(element).style.display !== 'none';
293+
return $(element).getStyle('display') !== 'none';
294294
}
295295

296296
/**

test/unit/dom_test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,10 @@ new Test.Unit.Runner({
290290
testElementVisible: function(){
291291
this.assertNotEqual('none', $('test-visible').style.display);
292292
this.assertEqual('none', $('test-hidden').style.display);
293+
294+
this.assert($('test-visible').visible());
295+
this.assert(!$('test-invisible').visible());
296+
this.assert(!$('test-hidden').visible());
293297
},
294298

295299
testElementToggle: function(){

test/unit/fixtures/dom.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22
<p id="scroll_test_2">Scroll test</p>
33
</div>
44

5+
<style type="text/css">
6+
#test-invisible { display: none; }
7+
</style>
8+
59
<div id="test-visible">visible</div>
10+
<div id="test-invisible">invisible</div>
611
<div id="test-hidden" style="display:none;">hidden</div>
712
<div id="test-toggle-visible">visible</div>
813
<div id="test-toggle-hidden" style="display:none;">hidden</div>

0 commit comments

Comments
 (0)