Fix bug that prevented the line length to be updated in some cases

marijnh · marijnh · commit 035f535ae8dc · 2011-06-07T12:58:16.000+02:00
(Which would make horizonal scrollbars 'stick' after the wide lines had
been deleted.)
diff --git a/lib/codemirror.js b/lib/codemirror.js
@@ -397,7 +397,7 @@ var CodeMirror = (function() {
 
     function updateLinesNoUndo(from, to, newText, selFrom, selTo) {
       var recomputeMaxLength = false, maxLineLength = maxLine.length;
-      for (var i = from.line; i < to.line; ++i) {
+      for (var i = from.line; i <= to.line; ++i) {
         if (lines[i].text.length == maxLineLength) {recomputeMaxLength = true; break;}
       }
 
@@ -436,7 +436,7 @@ var CodeMirror = (function() {
         }
       }
       if (recomputeMaxLength) {
-        maxLineLength = 0;
+        maxLineLength = 0; maxLine = "";
         for (var i = 0, e = lines.length; i < e; ++i) {
           var l = lines[i].text;
           if (l.length > maxLineLength) {

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ var CodeMirror = (function() {`
`397`	`397`
`398`	`398`	`function updateLinesNoUndo(from, to, newText, selFrom, selTo) {`
`399`	`399`	`var recomputeMaxLength = false, maxLineLength = maxLine.length;`
`400`		`- for (var i = from.line; i < to.line; ++i) {`
	`400`	`+ for (var i = from.line; i <= to.line; ++i) {`
`401`	`401`	`if (lines[i].text.length == maxLineLength) {recomputeMaxLength = true; break;}`
`402`	`402`	`}`
`403`	`403`
`@@ -436,7 +436,7 @@ var CodeMirror = (function() {`
`436`	`436`	`}`
`437`	`437`	`}`
`438`	`438`	`if (recomputeMaxLength) {`
`439`		`- maxLineLength = 0;`
	`439`	`+ maxLineLength = 0; maxLine = "";`
`440`	`440`	`for (var i = 0, e = lines.length; i < e; ++i) {`
`441`	`441`	`var l = lines[i].text;`
`442`	`442`	`if (l.length > maxLineLength) {`