Disable setDragImage call, which apparently caused Safari crashes

marijnh · marijnh · commit bb2847f404a9 · 2012-02-26T21:57:51.000+01:00
See issue #332
diff --git a/lib/codemirror.js b/lib/codemirror.js
@@ -462,9 +462,10 @@ var CodeMirror = (function() {
     }
     function onDragStart(e) {
       var txt = getSelection();
-      // This will reset escapeElement
-      htmlEscape(txt);
-      e.dataTransfer.setDragImage(escapeElement, 0, 0);
+      // Disabled until further notice. Doesn't work on most browsers,
+      // and crashes Safari (issue #332).
+      //htmlEscape(txt);
+      //e.dataTransfer.setDragImage(escapeElement, 0, 0);
       e.dataTransfer.setData("Text", txt);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -462,9 +462,10 @@ var CodeMirror = (function() {`
`462`	`462`	`}`
`463`	`463`	`function onDragStart(e) {`
`464`	`464`	`var txt = getSelection();`
`465`		`- // This will reset escapeElement`
`466`		`- htmlEscape(txt);`
`467`		`- e.dataTransfer.setDragImage(escapeElement, 0, 0);`
	`465`	`+ // Disabled until further notice. Doesn't work on most browsers,`
	`466`	`+ // and crashes Safari (issue #332).`
	`467`	`+ //htmlEscape(txt);`
	`468`	`+ //e.dataTransfer.setDragImage(escapeElement, 0, 0);`
`468`	`469`	`e.dataTransfer.setData("Text", txt);`
`469`	`470`	`}`
`470`	`471`