Fix: Broken line widget removal

fellmann · marijnh · commit e193f34844a1 · 2020-01-01T13:49:47.000+01:00
Removal of line widgets is broken in 5.50.0 due to invalid classname check
diff --git a/src/display/update_line.js b/src/display/update_line.js
@@ -127,7 +127,7 @@ function updateLineWidgets(cm, lineView, dims) {
   let isWidget = classTest("CodeMirror-linewidget")
   for (let node = lineView.node.firstChild, next; node; node = next) {
     next = node.nextSibling
-    if (isWidget.test(node)) lineView.node.removeChild(node)
+    if (isWidget.test(node.className)) lineView.node.removeChild(node)
   }
   insertLineWidgets(cm, lineView, dims)
 }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ function updateLineWidgets(cm, lineView, dims) {`
`127`	`127`	`let isWidget = classTest("CodeMirror-linewidget")`
`128`	`128`	`for (let node = lineView.node.firstChild, next; node; node = next) {`
`129`	`129`	`next = node.nextSibling`
`130`		`- if (isWidget.test(node)) lineView.node.removeChild(node)`
	`130`	`+ if (isWidget.test(node.className)) lineView.node.removeChild(node)`
`131`	`131`	`}`
`132`	`132`	`insertLineWidgets(cm, lineView, dims)`
`133`	`133`	`}`