Version 6.34.0 introduces a breaking change with cloneNode

[OldHippie67]

Describe the issue

The notes for version 6.34.0 state "...and uses cloneNode when a raw element is passed in ..."

Cloning a node does not copy event listeners added using addEventListener() or those assigned to element properties (e.g., node.onclick = someFunction). https://developer.mozilla.org/en-US/docs/Web/API/Node/cloneNode

An HTMLElement created like this

    const buttonElement = document.createElement("button");
    buttonElement.innerText = "Click Me";
    buttonElement.addEventListener("click", () => {
      console.log('Button in placeholder was clicked')
      });
    });

and passed to the placeholder method worked as expected in version 6.33.0

The same code does not work in version 6.34.0 because the event listener is not copied in version 6.34.0

Please consider making note of this breaking change in the notes for version 6.34.0 and adding this detail to the documentation for the placeholder method.

Browser and platform

No response

Reproduction link

No response

[gribnoysup]

Running into the same thing after an update, it would be nice if there was a way to opt-out of the cloning behaviour somehow to allow listeners to be preserved. For now what we are doing is overriding the cloneNode function on the element returned EDIT: as pointed out below you can just pass a function that returns the element instead of the constructed element

[marijnh]

it would be nice if there was a way to opt-out of the cloning behaviour somehow

There is: pass a function instead of a raw node. That way you still have complete control over the way the placeholder is created.

[gribnoysup]

Ahhh, I totally misread the ternary logic in the placeholder widget source, thanks for ponting this out!