Skip to content

Commit 1819167

Browse files
committed
Don't try to dispatch alt-something key combos by keycode on macOS
FIX: Make the keymap not dispatch Alt key combos on macOS by key code, because those are generally used to type special characters. Closes codemirror/dev#1583
1 parent b5737c1 commit 1819167

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/keymap.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,8 @@ function runHandlers(map: Keymap, event: KeyboardEvent, view: EditorView, scope:
252252
} else if (isChar && (event.altKey || event.metaKey || event.ctrlKey) &&
253253
// Ctrl-Alt may be used for AltGr on Windows
254254
!(browser.windows && event.ctrlKey && event.altKey) &&
255+
// Alt-combinations on macOS tend to be typed characters
256+
!(browser.mac && event.altKey && !event.ctrlKey) &&
255257
(baseName = base[event.keyCode]) && baseName != name) {
256258
if (runFor(scopeObj[prefix + modifiers(baseName, event, true)])) {
257259
handled = true

0 commit comments

Comments
 (0)